Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • xfce-4.18 protected
  • xfce-4.16 protected
  • xfce-4.14 protected
  • xfce-4.10 protected
  • xfce-4.12 protected
  • jannis/basic-monitoring
  • jannis/global-monitoring
  • parser-rewrite
  • garcon-4.21.0 protected
  • garcon-4.20.0 protected
  • xfce-4.20pre2 protected
  • garcon-4.19.3 protected
  • xfce-4.20pre1 protected
  • garcon-4.19.2 protected
  • garcon-4.18.2 protected
  • garcon-4.19.1 protected
  • garcon-4.19.0 protected
  • garcon-4.18.1 protected
  • garcon-4.18.0 protected
  • xfce-4.18pre2 protected
  • garcon-4.17.3 protected
  • xfce-4.18pre1 protected
  • garcon-4.17.2 protected
  • garcon-4.17.1 protected
  • garcon-4.17.0 protected
  • garcon-4.16.1 protected
  • garcon-4.16.0 protected
  • garcon-0.8.0 protected
29 results
Search by author
  • Any Author
  • Administrator Administrator root
  • Alexander Schwinn Alexander Schwinn alexxcons
  • Andre Miranda Andre Miranda andreldm
  • Brian Tarricone Brian Tarricone kelnos
  • Gaël Bonithon Gaël Bonithon Tamaranch
  • GitBot GitBot GitBot
  • Kevin Bowen Kevin Bowen kevinbowen
  • Landry Breuil Landry Breuil landry
  • Olivier Fourdan Olivier Fourdan olivier
  • Romain Bouvier Romain Bouvier skunnyk
  • Sean Davis Sean Davis bluesabre
  • Sergios - Anestis Kefalidis Sergios - Anestis Kefalidis SKefalidis
  • Simon Steinbeiß Simon Steinbeiß ochosi
  • Theo Linkspfeifer Theo Linkspfeifer lastonestanding
  • Yongha Hwang Yongha Hwang MShrimp4
  • Yousuf Philips Yousuf Philips philipzae
16 authors
  1. Mar 13, 2023
  3. Mar 12, 2023
  5. Feb 25, 2023
    • Gaël Bonithon's avatar
      garcon-gtk: Add missing lock when filling the GtkMenu · 4a053d16
      Gaël Bonithon authored 
      Another special case not properly locked: this filling can start while
the GarconMenu is loading, because its status is updated only at the end
of the loading.

The other occurrence of `garcon_gtk_menu_add()` that fills the root menu
is protected because it is in the GAsyncReadyCallback, so after the task
is finished and before another one is started. As for the third
occurrence of `garcon_gtk_menu_add()` which fills sub-menus, it is
protected by `g_signal_connect_object()` which keeps a reference on the
sub-GarconMenu.

Fixes criticals such as
"g_node_last_child: assertion 'node != NULL' failed".

Fixes: d2c7068e
Related: !18
      4a053d16
  7. Feb 16, 2023
    • Gaël Bonithon's avatar
      Wait for any async operation to finish before releasing locks · 84fa5fa6
      Gaël Bonithon authored 
      As the doc states, calling `g_mutex_clear()` on a locked mutex leads to
undefined behavior. This can happen at least in the case of GarconMenu,
where a load may be in progress at the time the last reference is
removed in GarconGtkMenu. This can be reproduced by reloading the panel
configuration via xfce4-panel-profiles when a custom menu file is used.

Fixes: 966f7c99
Related: !18
      84fa5fa6
  9. Jan 20, 2023
  11. Jan 14, 2023
    • Brian Tarricone's avatar
      Use GIcons for menu icons instead of loading surfaces · f66a4780
      Brian Tarricone authored 
      It turn out GtkImage automatically takes UI scale factor into account
when loading images from GIcons.  This allows us to avoid having to
thread through the scale factor everywhere, and also means we don't need
to do anything when the scale factor changes.
      f66a4780
  13. Jan 13, 2023