An `else` statement was left after the recent code rework.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15852

Previous attempt to fix a crash with a screensize of 0, which can occur
without any output connected was incomplete (commit 3925109d) as a
client might still trigger a repaint by queuing up damages.

Make sure we take this case into account as well.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Simon Steinbeiss authored 5 years ago and Olivier Fourdan committed 4 years ago

Bug: #16382

After hovering the currently selected item the tabwin would be left
without a selected item. This patch makes sure that on the leave event
the selected item regains its selected style.

Also switch from GTK_STATE_FLAG_ACTIVE to GTK_STATE_FLAG_CHECKED.

Andre Miranda authored 4 years ago and Olivier Fourdan committed 4 years ago

Bug: 16644

GTimeVal is deprecated, use the GDK API du jour instead.

Bug: 16649

With Xi2 we need to use Xi2 routines.

But some client may issue standard X11 core protocol grabs the on the
client window.

Grabs from the standard core protocol and Xi2 grabs do not mix well.

So instead of ditching the Xi2 grabs, we issue the core protocol first,
check that it succeeds and only if that works we can issue the Xi2
grabs.

That keeps the Xi2 grabs logic while fixing the issue with X-AIR-Edit
which uses a passive grab on the pointer using core X11 protocol.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16649

This reverts commit aa3e3cac.

Bug: 16347

XInput2 passive button grab would not fail if the button is already
grabbed by the client.

X-AIR-Edit is such a client which issues a button grab on its own
window, meaning that with XI2 button it would not react to button events
anymore.

Revert to the standard grab button for the passive grabs so that such
apps can still work with xfwm4.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16348

When moving a maximized window, we would not restore the actual window
state.

With client-side decorations, that prevents shadows from being enabled.

Make sure to restore the actual client state when moving.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16067

The font height might be wrong, just get rid of it.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16274

Blacklist the GL renderer "SVGA3D" to disable GL on Virtualbox.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Simon Steinbeiss authored 5 years ago and Olivier Fourdan committed 4 years ago

Bug: 16381

This can lead to misleading situations, e.g. if you have >1 display and
the edge of the next display is blurry/dark for no obvious reason.

Bug: 15984

When running remotely, the hostname would not show in the title initially.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15966

When using wireframe move/resize along with transparent window
decorations, the window would appear to move along with the frame.

This is because the move/resize operation updates the internal data
that the compositor uses for drawing the client decorations with a
different opacity.

To avoid the issue, just use the actual window positio nand size.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15974

Raise delay would be ignored, because on focus change, the newly
focused window would be raised as soon as it receives focus.

Use the raise delay timeout instead of raising the window immediately
so that the raise delay remains functional.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The documentation for `EXT_texture_from_pixmap` states that a
compositor should bind and release the texture each time:

    [...]
    glXBindTexImageEXT()

    <Do rendering/compositing>

    glXReleaseTexImageEXT()
    [...]

Fix the compositor to adhere to the specification.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

If there is no primary monitor, i.e. because no monitor at all, there is
no point in updating the workarea.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15852

If no monitor is connected for a given screen, it's reported size will
be 0.

In that case, trying to repaint the screen using GLX for vsync will
crash.

Add a test to make sure the size of the screen is a thing, before
queuing up a repaint.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15884

That was inadvertently removed by commit 8a16ca2e - “menu: Remove
icons from window menu”.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15709

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 6caed779)

Bug: 15580

Following commit fa9517ea (“Raise all transients together”), xfwm4
would search for the deepest parent of a given transient and raise it to
bring all related windows together.

however, taking into account parents from the same group, it would raise
the lowest window while the others from the same group aren't raised
along with it, causing apparently random windows to be raised.

Make sure we pick only direct transients when walking down the windows
stack.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 14959

Place dialogs without parent on the current monitor, i.e. the monitor
where the pointer currently resides.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

This breaks zooming without GLX, reverting.

This reverts commit 18721a1a.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Juha Aatrokoski authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 15676

Between versions 4.13.1 and 4.13.2 the GL_NEAREST filter (used on the
deepest levels of desktop zoom) stopped working, and GL_LINEAR was
used instead. Fix by setting GL_TEXTURE_MIN_FILTER in addition to
GL_TEXTURE_MAG_FILTER, like was done in version 4.13.1; apparently the
former needs to be correctly configured for the latter to take effect.

Signed-off-by: Juha Aatrokoski <jha@iki.fi>

Also increase the timeout value to be just above the default priority.

Suggested-by:  <howaboutsynergy@protonmail.com>
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Using icons in menu is deprecated, remove them.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 13954

Some clients tend to send us a configure request when transitioning to
maximized, which introduces a race condition because the window manager
will remove the maximized flag when the client resizes itself, now that
we allow for that since commit aee8b25a.

Ignore the configure size request from the client when maximized or
fullscreen to work around such behavior from the client.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15638

Ignoring all configure requests when maximized or fullscreen is overkill
and prevent valid use cases from working.

This reverts commit 3751c2c7.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15584

Rephrase “Minimize _All Other Windows”
      to “Minimize _Other Windows”

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Iharob Al Asimi authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 15510

Use the WM_CLASS property and extract the instance name from it, then
use GtkIconTheme to determine the icon that should be used in place of
the missing icon.

There is no reason for `getAppIcon()` API to differ from its counterpart
`getClientIcon()`.

Use the same API so for both.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Now that we ship the default theme in different sizes, adjust the
default theme based on scale.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

So that we don't show random data until the whole screen is refreshed.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The grey color was useful mainly for debugging the compositor and drop
shadows, but it looks just plain ugly at startup.

Change it to black, so it is not as noticeable on startup, before
xfdesktop takes over the background.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug 15554

The API was added in epoxy 1.4.0, most distribution don't have it yet.

This reverts commit 1311eecd.

`xfwm_get_primary_monitor_geometry` returns logical dimensions instead
of device dimensions, which leads to incorrect `_NET_WORKAREA`
calculation.

As destroy_glx_drawable().

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Instead of passing the pixmap id around.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Just check if TIMEOUT_REPAINT is defined, and use the default priority
as value for timeout.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15453

This was added to avoid flickering with NVIDIA proprietary/closed source
driver (commit f75652eb - "Add back the glXWaitGL to compositor sync
code"), but that translates as a busy wait, hence increasing CPU usage
of xfwm4 with the NVIDIA proprietary/closed source driver.

By setting “__GL_MaxFramesAllowed” to 1, that busy wait should not be
needed anymore.

As a bonus, it also improve responsiveness with with the open source
drivers.

Taken from similar patch posted by NVIDIA developer for kwin:
https://phabricator.kde.org/D19867



Signed-off-by: Olivier Fourdan <fourdan@xfce.org>