The documentation for `EXT_texture_from_pixmap` states that a
compositor should bind and release the texture each time:

    [...]
    glXBindTexImageEXT()

    <Do rendering/compositing>

    glXReleaseTexImageEXT()
    [...]

Fix the compositor to adhere to the specification.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

If there is no primary monitor, i.e. because no monitor at all, there is
no point in updating the workarea.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15852

If no monitor is connected for a given screen, it's reported size will
be 0.

In that case, trying to repaint the screen using GLX for vsync will
crash.

Add a test to make sure the size of the screen is a thing, before
queuing up a repaint.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15884

That was inadvertently removed by commit 8a16ca2e - “menu: Remove
icons from window menu”.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15709

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 6caed779)

Bug: 15580

Following commit fa9517ea (“Raise all transients together”), xfwm4
would search for the deepest parent of a given transient and raise it to
bring all related windows together.

however, taking into account parents from the same group, it would raise
the lowest window while the others from the same group aren't raised
along with it, causing apparently random windows to be raised.

Make sure we pick only direct transients when walking down the windows
stack.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 14959

Place dialogs without parent on the current monitor, i.e. the monitor
where the pointer currently resides.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

This breaks zooming without GLX, reverting.

This reverts commit 18721a1a.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Juha Aatrokoski authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 15676

Between versions 4.13.1 and 4.13.2 the GL_NEAREST filter (used on the
deepest levels of desktop zoom) stopped working, and GL_LINEAR was
used instead. Fix by setting GL_TEXTURE_MIN_FILTER in addition to
GL_TEXTURE_MAG_FILTER, like was done in version 4.13.1; apparently the
former needs to be correctly configured for the latter to take effect.

Signed-off-by: Juha Aatrokoski <jha@iki.fi>

Also increase the timeout value to be just above the default priority.

Suggested-by:  <howaboutsynergy@protonmail.com>
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Using icons in menu is deprecated, remove them.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 13954

Some clients tend to send us a configure request when transitioning to
maximized, which introduces a race condition because the window manager
will remove the maximized flag when the client resizes itself, now that
we allow for that since commit aee8b25a.

Ignore the configure size request from the client when maximized or
fullscreen to work around such behavior from the client.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15638

Ignoring all configure requests when maximized or fullscreen is overkill
and prevent valid use cases from working.

This reverts commit 3751c2c7.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15584

Rephrase “Minimize _All Other Windows”
      to “Minimize _Other Windows”

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Iharob Al Asimi authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 15510

Use the WM_CLASS property and extract the instance name from it, then
use GtkIconTheme to determine the icon that should be used in place of
the missing icon.

There is no reason for `getAppIcon()` API to differ from its counterpart
`getClientIcon()`.

Use the same API so for both.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Now that we ship the default theme in different sizes, adjust the
default theme based on scale.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

So that we don't show random data until the whole screen is refreshed.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The grey color was useful mainly for debugging the compositor and drop
shadows, but it looks just plain ugly at startup.

Change it to black, so it is not as noticeable on startup, before
xfdesktop takes over the background.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug 15554

The API was added in epoxy 1.4.0, most distribution don't have it yet.

This reverts commit 1311eecd.

`xfwm_get_primary_monitor_geometry` returns logical dimensions instead
of device dimensions, which leads to incorrect `_NET_WORKAREA`
calculation.

As destroy_glx_drawable().

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Instead of passing the pixmap id around.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Just check if TIMEOUT_REPAINT is defined, and use the default priority
as value for timeout.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15453

This was added to avoid flickering with NVIDIA proprietary/closed source
driver (commit f75652eb - "Add back the glXWaitGL to compositor sync
code"), but that translates as a busy wait, hence increasing CPU usage
of xfwm4 with the NVIDIA proprietary/closed source driver.

By setting “__GL_MaxFramesAllowed” to 1, that busy wait should not be
needed anymore.

As a bonus, it also improve responsiveness with with the open source
drivers.

Taken from similar patch posted by NVIDIA developer for kwin:
https://phabricator.kde.org/D19867



Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15453

NVIDIA proprietary/closed source driver queues up to 2 frames by default
before blocking in glXSwapBuffers(), whereas our compositor expects
`glXSwapBuffers()` to block until the next vblank.

To avoid that, our compositor is issuing a `glXWaitGL()` immediately
after the call to `glXSwapBuffers()` but that translates as a busy wait,
hence dramatically increasing CPU usage of xfwm4 with the NVIDIA
proprietary/closed source driver.

Instruct the NVIDIA proprietary/closed source driver to allow only 1
frame using the environment variable “__GL_MaxFramesAllowed” so that it
matches our expectations.

Taken from similar patch posted by NVIDIA developer for kwin:
https://phabricator.kde.org/D19867



Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Instead of the buffer id.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Change the newly added “frame_border_top” setting to set the size of
the top resize handle as well.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15432

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15432

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Adam K authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 14470

Themes can take advantage of this with the frame_border_top property.
Existing themes without that property will not be affected or broken.

Signed-off-by: Adam K <chkboom@safe-mail.net>

Adam K authored 5 years ago and Olivier Fourdan committed 5 years ago

Signed-off-by: Adam K <chkboom@safe-mail.net>

Reset the fence after the last buffer access to make sure it's fully and
reliably completed before the next GL buffer swap.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Fix a typo when initializing the pointer location when starting to zoom
in.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Not need to change clipping after painting the cursor with GLX, we don't
use it anymore after that point.

But we need to reset the fence just before painting the cursor otherwise
the fence will be triggered too soon, causing flicker.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>