Bug: 15584

Rephrase “Minimize _All Other Windows”
      to “Minimize _Other Windows”

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Iharob Al Asimi authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 15510

Use the WM_CLASS property and extract the instance name from it, then
use GtkIconTheme to determine the icon that should be used in place of
the missing icon.

There is no reason for `getAppIcon()` API to differ from its counterpart
`getClientIcon()`.

Use the same API so for both.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Now that we ship the default theme in different sizes, adjust the
default theme based on scale.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

So that we don't show random data until the whole screen is refreshed.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The grey color was useful mainly for debugging the compositor and drop
shadows, but it looks just plain ugly at startup.

Change it to black, so it is not as noticeable on startup, before
xfdesktop takes over the background.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug 15554

The API was added in epoxy 1.4.0, most distribution don't have it yet.

This reverts commit 1311eecd.

`xfwm_get_primary_monitor_geometry` returns logical dimensions instead
of device dimensions, which leads to incorrect `_NET_WORKAREA`
calculation.

As destroy_glx_drawable().

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Instead of passing the pixmap id around.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Just check if TIMEOUT_REPAINT is defined, and use the default priority
as value for timeout.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15453

This was added to avoid flickering with NVIDIA proprietary/closed source
driver (commit f75652eb - "Add back the glXWaitGL to compositor sync
code"), but that translates as a busy wait, hence increasing CPU usage
of xfwm4 with the NVIDIA proprietary/closed source driver.

By setting “__GL_MaxFramesAllowed” to 1, that busy wait should not be
needed anymore.

As a bonus, it also improve responsiveness with with the open source
drivers.

Taken from similar patch posted by NVIDIA developer for kwin:
https://phabricator.kde.org/D19867



Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15453

NVIDIA proprietary/closed source driver queues up to 2 frames by default
before blocking in glXSwapBuffers(), whereas our compositor expects
`glXSwapBuffers()` to block until the next vblank.

To avoid that, our compositor is issuing a `glXWaitGL()` immediately
after the call to `glXSwapBuffers()` but that translates as a busy wait,
hence dramatically increasing CPU usage of xfwm4 with the NVIDIA
proprietary/closed source driver.

Instruct the NVIDIA proprietary/closed source driver to allow only 1
frame using the environment variable “__GL_MaxFramesAllowed” so that it
matches our expectations.

Taken from similar patch posted by NVIDIA developer for kwin:
https://phabricator.kde.org/D19867



Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Instead of the buffer id.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Change the newly added “frame_border_top” setting to set the size of
the top resize handle as well.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15432

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15432

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Adam K authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug: 14470

Themes can take advantage of this with the frame_border_top property.
Existing themes without that property will not be affected or broken.

Signed-off-by: Adam K <chkboom@safe-mail.net>

Adam K authored 5 years ago and Olivier Fourdan committed 5 years ago

Signed-off-by: Adam K <chkboom@safe-mail.net>

Reset the fence after the last buffer access to make sure it's fully and
reliably completed before the next GL buffer swap.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Fix a typo when initializing the pointer location when starting to zoom
in.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Not need to change clipping after painting the cursor with GLX, we don't
use it anymore after that point.

But we need to reset the fence just before painting the cursor otherwise
the fence will be triggered too soon, causing flicker.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The new fence scheduling we're using now is causing flickering,
revert to the previous way of dealing with the fence.

This reverts commit 340f9e82.

Reported-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

If present flip failed, we should not wait for the flip notification
that will never arrive.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

It's not worth keeping XPresent active if it generates XErrors.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

`present_flip()` now takes the buffer number instead of the rendering
buffer.

Fix the caller to pass the appropriate expected value.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 14741

Clicking a window title button would keep the button pressed even after
the pointer leaves the button.

This is just a simple case of receiving multiple enter/leave events
without actually checking for the window, so any additional enter events
received after the leave event would let the button in a pressed state.

Fix the issue by checking for the actual event window against the button
window.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15400

Dialog windows which have no parent should not be skipped from taskbar.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15399

If a client specifies an invalid NET_WM_WINDOW_TYPE, fallback to normal
window type.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 14741

For button enter/leave events, checking the crossing mode prevents the
events from being handled.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15384

Commit f5da3d66 cause a serious regression by preventing the filter to
be run on any window but the one being grabbed.

This reverts commit f5da3d66.

The number of buffers we need to allocate/manage depends on the feature
enabled at build time.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Basically, we want the fence to prevent GL from accessing the pixmap
buffer until its update is complete.

However, depending on the code path, we may update the buffer more than
once, so to prevent any flickering, we need a finer grain control over
the fence operations.

Split the fence support into different actions as we need them, i.e.
create, destroy, reset, trigger and wait.

Make sure we reset the fence before each time we are to update the
pixmap buffer and wait for the fence just before doing the GL swap.

Also create a different fence for each buffer, so if ever decide to use
multiple buffers with GL, the existing code will be able to support that
and not use the same fence for multiple pixmaps.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>