bob5972 authored 4 years ago and Olivier Fourdan committed 4 years ago

The function free_win_data() may generate X11 errors as the client
window may already be gone.

To avoid those, the entire function code is supposed to be enclosed
within an error trap/push.

A typo in the code would however push twice instead of a balanced
push/pop which causes the list of event sequences in GDK to grow
indefinitely, leading to slowdowns as the list grows over time.

Fix the leak by balancing the error push with an error pop at the end
of the function.

#351
(cherry picked from commit e6a32cf7)

The function compositorCheckCMSelection() would use the atom index in
our table of atoms, instead of the actual atom, so this is unlikely to
work as expected.

Fix the code to use the appropriate atom as it should.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 78c5dc42)

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

OlivierDuchateau authored 4 years ago and Olivier Fourdan committed 4 years ago

(cherry picked from commit d3e2c246)

A pid is not necessarily a long on all systems, so casting the value of
NET_WM_PID directly into a GPid may cause a stack overflow.

Fixes: 49c1a33a
Closes: #411


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit a691e6c50ce2d797183c98bc2e9c72b8bb2b2a5a)

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Add more XError traps related to XConfigureWindow requests.

#405


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit ec3b1b12)

To be on the safe side.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 9351d439)

The gvalues strings were considered statics, hence not duplicated.

As the caller frees the strings after setting the gvalue, the actual
content would end up pointing at free data.

Consider string gvalues as regular strings, meaning that the given
string value is duplicated as a gvalue.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #406
(cherry picked from commit 056ba6ad)

When xfwm4 needs to kill an unresponsive client, it will use the its PID
is known.

However, the _NET_WM_PID as defined in the extended window manager hint
mechanism is unreliable when the client runs within a sandbox, as it is
the client itself who sets that property using its own view of the PID.

The Xserver can provide a more accurate value of the client PID using
the XRes X11 extension, so use that protocol if available.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 49c1a33a)

The X-Resource extension client library (XRes) allows a client to query
the Xserver for various resources associated with an X11 client,
including its PID.

Add (optional) support for XRes in xfwm4 and use it for getting the
client's PID instead of relying on _NET_WM_PID.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 010f8281)

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

164 translated messages, 5 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

122 translated messages, 47 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

89 translated messages, 80 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

86 translated messages, 83 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16716

Prefer GLX for vblank on AMD, until the issue is fixed in the Xorg DDX.

See-also: https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/merge_requests/52


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16713

If one of the required X11 extension is not available, the compositor
cannot be used.

Yet xfwm4 would still try to enable the compositor for each screen,
which would not work and prevent xfwm4 from starting.

If we can't use the compositor, well, we'd better not use it...

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit 2c78273d)

Clicking outside the tab-win would cancel the selection, make sure to
revert to the original first window of the list in that case, it feels
more natural and predictible.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit e268df73)

Bug: 16713

Without XRender, the mask would be misrendered and completely
transparent.

As a result, the entire pixmap would become totally transparent and all
window decorations become invisible.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit 7bd23e3f)

Bug: 16708

With Xi2, the clients needs to reset the valuators (for mouse wheel)
themselves, usually on focus events.

Qt instead does that on EnterNotify, but ignores the EnterNotify events
resulting from grabs first. This is a bug in Qt as that prevents the
valuators to be reset if the pointer enters the window while grabbed.

Precisely, xfwm4 would issue a pointer grab while cycling to prevent
from random button events, and would only ungrab after the client window
is raised and focused.

While this is a bug in Qt, we can still work around the issue in xfwm4
by not issuing a pointer grab and simply abort the window cycling when a
click occurs outside of the alt-tab window.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit d2cf2e80)

Update the Pango attributes when the widget font factor is updated, then
repaint all frames.

With this, changing the scaling factor in the appearance settings
updates the title font dynamically as well.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit 308512e1)

Bug: 16067

The font height is not used anymore, remove it.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit 065a1204)

Bug: 16067

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit e3bf9ae5)

Bug: 16711

We need to keep the pango font attributes for the scale with HiDPI.

This reverts commit 34a31e27.

(cherry picked from commit fbd07808)

Bug: 16383

If the window has vanished, the XShape request will fail.

Make sure all XShape requests are protected by error traps.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

(cherry picked from commit ad33f686)

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).