It is complicated to make this working properly for unmounted resources;
The new view will not show the correct location. So let's simply do nothing
when the user clicks on an unmounted resource; the user can click on the
item with the left mouse button to mount it, then middle-click it to open
it in a new tab or window.

When middle-clicking on an item in the tree view, the cursor will be set
on the clicked item so that the new tab/window will show this item. However,
the original tree view should still show the old location and behave as if
the middle-click did not happen.

This is the inverse operation of mounting with KEY_Right.

In the treeview the network item has a standard directory icon unlike
in all other places. This commit fixes this.

Mounting a device in the tree view always opens them in a new tab,
instead of in the current view. This commit fixes this.

If the user navigates the treeview using the up and down keys and a
device is not mounted, then it will be mounted. It is better for user
experience to only mount the device when the user expands the path
with Key_Right, otherwise some items in the treeview might not even
be accessible without accidentally mounting other devices.

Gtk-CRITICAL **: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

Since the toplevel item issue is fixed now, this is no longer necessary
and can be reverted.

When the user clicks on e.g. "Desktop" in the treeview, the treeview
will expand the tree and set the cursor on home/Desktop instead on the
proper toplevel item (assuming the Desktop folder resides in the user's
home directory of course). This is very bad for user experience.

To fix this, this commit makes the treeview

a) use the cursor if set to limit the search to below the current
   toplevel item
b) select the proper toplevel item to expand to the descendant in the
   following order:
   1) any mounted device or network resource
   2) the user's desktop directory
   3) the user's home directory
   4) the root filesystem

When trying to go back or forward in history, and the target location
has been unmounted, remove the entry from the history.

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

722 translated messages, 16 untranslated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

https://developer.gnome.org/gio/unstable/GFileMonitor.html#GFileMonitorEvent:
G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT:
"A hint that this was probably the last change in a set of changes."

Reloading file information can be costly, so it may be wise to only do this
after a set of changes has been performed, which is not emitted as often
as the CHANGED and ATTRIBUTE_CHANGED hint.

The G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT will always be emitted after
G_FILE_MONITOR_EVENT_CHANGED and G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED,
so wait for it with the reload.

Possible risks: On some (especially remote?) file systems, the EVENT_CHANGED
and ATTRIBUTE_CHANGED might take a while to be processed, resulting in the
reload happening later. But then, why would it be faster to reload the
file before all these changes have been done?

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

734 translated messages, 4 untranslated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

This partly reverts the previous commit which was not correct,
and fixes the real problem which can be seen when cancelling editing.

This fixes the shortcut renaming feature broken by f60acf89
"Allow <ctrl> + middle click in shortcut and treeview panes" and
also removes the weird-looking "selection in selection" which maybe can
only be noticed by some themes, but is reproducible with Greybird.

Show spaces in the path names instead of "%20".

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

Unfortunately, the previous commit did not work correctly for local paths
in all cases. This commit fixes this by distinguishing between local paths
and URIs.

Escaping the URI in thunar_path_entry_changed is necessary for correctly
loading the corresponding ThunarFile for the GFile.

This solves bug #8910 where the problem stems from URI unescaping,
resulting in the unescaped text being NULL. This is handled by the
second part of the patch, which falls back to the unescaped text.

Without this commit, directories containing characters like "%", e.g
"test%folder", can be opened but

1) on remote locations the icon in the toolbar location selector will
   show an error indicating there is something wrong,
2) while on local filesystems only the parent path will be shown in
   the path entry.

When clicking on a tree view item, the main view will open it and thus
grab the focus. This focus change may be a bit unexpected to the user,
but trivial to fix, so make the tree view keep the focus after such a
button click.

This fixes the following bug:

1) Create two directories (a and b).
2) Open them in tabs in a thunar window.
3) Switch to the tab currently showing a and delete b from a terminal.

Expected behaviour:
Inactive tab showing b will switch to the parent directory.
Active tab showing a will be unaffected.

Actual behaviour:
Inactive tab showing b will switch to the parent directory.
Active tab showing a will not change the directory.

Instead of trying to keep the selected files in view when rows get
reordered, leave the scroll position unchanged. Otherwise, the user
might not be able to select files easily.

By setting fix lower/upper limits for the scrolled window alignments
we make sure that the view does not flicker because the position
would change twice.

Commit 4d19f45f "Restore selection on row changes too (bug #9886)"
forced the file selection to be restored on row changes, which has the
negative side effect that the view will also scroll to the selected
file(s) whenever such a change happens, e.g. when thumbnailing finishes.

The better fix is to listen to the rows-reordered signal which no view
listens to at the moment. This commit implements this.

Files usually have extensions, but most folders do not. This is also the
way the renamer dialog treats filenames, so the behaviour should be the
same.

Evangelos Foutras authored 9 years ago and Harald Judt committed 9 years ago

In commit b839b29d (Extend reload
functions to allow a full reload) an extra parameter was added to
reload functions that specifies whether file information should be
reloaded as well.

This can cause an infinite loop as described in the bug report.

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

CID 60623 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value from event->x to path_entry->drag_x here,
but that stored value is overwritten before it can be used.

...

value_overwrite: Overwriting previous write to path_entry->drag_x with
value from event->y.

CID 60621 (#1 of 1): Missing return statement (MISSING_RETURN)
5. missing_return: Arriving at the end of a function without
returning a value.