bob5972 authored 4 years ago and bob5972 committed 4 years ago

The call to g_timeout_add in add_repair seems to be mixing up priority
and callback interval.  Instead, let's call g_timeout_add_full to make
it clear there are two separate fields, and add an appropriate define
for the callback interval, setting it to the same 1ms value it was
currently using.

Signed-off-by: Michael Banack <bob5972@banack.net>

172 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

171 translated messages, 2 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

128 translated messages, 45 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

170 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

This is a development preview release.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

bob5972 authored 4 years ago and Olivier Fourdan committed 4 years ago

On my system, 2-4% of the CPU time in xfwm4 is being spend in
find_cwindow_in_screeni() pulling in entries from the linked list on
a lightly updating desktop.

After this change, 25-50% of that CPU is gone, presumably because the
slice allocators have better locality of the list-entries.

Closes: #416

bob5972 authored 4 years ago and Olivier Fourdan committed 4 years ago

The function free_win_data() may generate X11 errors as the client
window may already be gone.

To avoid those, the entire function code is supposed to be enclosed
within an error trap/push.

A typo in the code would however push twice instead of a balanced
push/pop which causes the list of event sequences in GDK to grow
indefinitely, leading to slowdowns as the list grows over time.

Fix the leak by balancing the error push with an error pop at the end
of the function.

#351

The function compositorCheckCMSelection() would use the atom index in
our table of atoms, instead of the actual atom, so this is unlikely to
work as expected.

Fix the code to use the appropriate atom as it should.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Prefer using memory allocation functions which initialize the memory
with 0's to be on the safe side.

No functional change.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

This is a development preview release.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

A pid is not necessarily a long on all systems, so casting the value of
NET_WM_PID directly into a GPid may cause a stack overflow.

Fixes: 49c1a33a
Closes: #411


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Dridi Boukelmoune authored 5 years ago and Olivier Fourdan committed 4 years ago

If the user selected a primary monitor, the Alt+Tab window will only
appear on that monitor, otherwise on all of them.

To quote the GDK documentation for gdk_display_get_primary_monitor:

> [...], specialized desktop applications such as panels should place
> themselves on the primary monitor.

It is however not possible to use gdk_display_get_primary_monitor and
also respect the user's setting. Despite what the online documentation
says, recent versions of GTK+3 may no longer return a null value and
will instead pick one monitor as the primary if there isn't already one
defined. The nullable marker [1] for the return value was eventually
dropped.

In other words, whether the user selected a primary monitor or not
gdk_display_get_primary_monitor will always return one.

Signed-off-by: Dridi Boukelmoune <dridi@fedoraproject.org>

[1] https://gitlab.gnome.org/GNOME/gtk/commit/76d95c312dde

Dridi Boukelmoune authored 4 years ago and Olivier Fourdan committed 4 years ago

Signed-off-by: Dridi Boukelmoune <dridi@fedoraproject.org>

Dridi Boukelmoune authored 5 years ago and Olivier Fourdan committed 4 years ago

It's a shorthand for gdk_monitor_is_primary when working from a screen.

Signed-off-by: Dridi Boukelmoune <dridi@fedoraproject.org>

Add more XError traps related to XConfigureWindow requests.

#405


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

To be on the safe side.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The gvalues strings were considered statics, hence not duplicated.

As the caller frees the strings after setting the gvalue, the actual
content would end up pointing at free data.

Consider string gvalues as regular strings, meaning that the given
string value is duplicated as a gvalue.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #406

Commit 821ee7cc would not actually send the synthetic configure notify
events anymore. That obviously breaks plenty of applications…

While the logic of the commit itself is sound, the problem is that it
bases the descision to send the configure notify event by comparing
against the current window size and location.

The problem is that the current window size and location is modified in
various places, defeating the logic.

Add an “applied_geometry” rectangle that we update only in a single
place in the code, so that we know exactly when to send a synthetic
configure notify event.

Closes: #403


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The size and position of the client are stored at multiple occasions.

But the naming of the variables used is a bit confusing, rename the
variables and use GdkRectangles instead.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

171 translated messages, 2 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

xfwm4 would send a synthetic configure event while resizing the client
window, which is not what the ICCCM states.

Fix this by sending the synthetic configure event only when necessary,
as per the ICCCM specification.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Avoid setting the same flag twice in a row, we already set the
CFG_REQUEST just a few line above.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Some client do not process events on their temporary windows, causing
the client unresponsive dialog to show up.

Avoid pinging the client on focus in, even though this is clearly a
client bug.

This reverts commit 637d70b2.

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

170 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).