Commit 4d19f45f "Restore selection on row changes too (bug #9886)"
forced the file selection to be restored on row changes, which has the
negative side effect that the view will also scroll to the selected
file(s) whenever such a change happens, e.g. when thumbnailing finishes.

The better fix is to listen to the rows-reordered signal which no view
listens to at the moment. This commit implements this.

Files usually have extensions, but most folders do not. This is also the
way the renamer dialog treats filenames, so the behaviour should be the
same.

Evangelos Foutras authored 9 years ago and Harald Judt committed 9 years ago

In commit b839b29d (Extend reload
functions to allow a full reload) an extra parameter was added to
reload functions that specifies whether file information should be
reloaded as well.

This can cause an infinite loop as described in the bug report.

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

CID 60623 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value from event->x to path_entry->drag_x here,
but that stored value is overwritten before it can be used.

...

value_overwrite: Overwriting previous write to path_entry->drag_x with
value from event->y.

CID 60621 (#1 of 1): Missing return statement (MISSING_RETURN)
5. missing_return: Arriving at the end of a function without
returning a value.

CID 60620 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
17. var_deref_model: Passing null pointer file_list to
thunar_application_unlink_files, which dereferences it.

CID 60619 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
20. var_deref_op: Dereferencing null pointer left_button.

CID 60617 (#1 of 1): Unchecked return value (CHECKED_RETURN)
1. check_return: Calling gtk_tree_model_get_iter_first without
checking return value (as is done elsewhere 4 out of 5 times).

Fix gcc warning.

This functionality is now provided by libxfce4ui, see commit
8990efaf "Use the spawn code from libxfce4ui."

When using the left mouse button, clicking on the first column of an item
will select it or initiate dragging, but rubber banding is deactivated.
For the other columns, only rubber banding will be possible and dragging
be disabled.

When using the right mouse button, clicking on the first column of an
item will always select it and pop up the context menu of the item.
Clicking on another column of an unselected item will unselect all
items and show the menu of the folder, while clicking on another
column of a selected item will show the context menu for that item
(or those items).

An extensive explanation has been added to the thunar docs in the wiki:
http://docs.xfce.org/xfce/thunar/working-with-files-and-folders

With the changes introduced in 4d19f45f "Restore selection on row
changes too (bug #9886)", slight flicker can be noticed when navigating
with forward/back actions. This is because row-changed events sometimes
cause a restore of the selection multiple times.

To solve this, this commit adds a short timeout for restoring the
selection in a similar way as for the status bar text updates.

Usually a folder is reloaded automatically on file changes, and the user
shouldn't have to do it manually. However, when the user *wants* to do
it manually, everything is expected to be reloaded, even the files in
cache, because their info may have changed. At the moment, this does not
happen, and there can be various issues with cached file info, so extension
is a first step to allow the user to decide to reload everything in the
folder.

Remove thunar-marshal from .gitignore, this needs to be tracked.

If a file is in the cache, schedule a reload of the file when idle.
This way file information gets updated properly when necessary and
without any crashes.

When a file has been moved, it will trigger a G_FILE_MONITOR_EVENT_MOVED
in thunar-folder.c, with the target file saved in other_file. While we
reload the folder, that only fetches the info for the target file from
the file info cache, which still contains the information of the replaced
file. So issue a reload of the target file to update the file information
properly, and also a reload of the folder containing the target file if
it is not the same as the folder of the source file.

This reverts commit cc8d1331,
which proved to cause crashes due to threading issues.

735 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

Show the correct path in the location bar after the user has
reloaded the folder manually from the menu or from the button
in the location bar.

This improves UI feedback and is also the standard behaviour
in other applications.

https://developer.gnome.org/gtk3/stable/GtkUIManager.html#gtk-ui-manager-insert-action-group

"Inserts an action group into the list of action groups associated with manager.
 Actions in earlier groups hide actions with the same name in later groups.
 If pos is larger than the number of action groups in manager, or negative,
 action_group will be inserted at the end of the internal list."

Always keep the window actions (group "ThunarActions") at the top of the
internal list of the GTK UI manager, so that they appear earlier. This
way, the shortcuts will not be lost, and the custom actions for the
context menu created by ThunarStandardView will work properly nonetheless.

Also update the UI manager immediately after inserting the action group,
otherwise GClosure warnings will spawn on stdout:
"g_closure_add_invalidate_notifier: assertion 'closure->n_inotifiers <
 CLOSURE_MAX_N_INOTIFIERS' failed
 unable to remove uninstalled invalidation notifier"

This is analogous to 02baccc0.

These functions are needed for keeping the history when a view changes,
or when a new window or tab is opened that should inherit the history
of the origin view.

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).