Related: xfce4-dev-tools#41

Another special case not properly locked: this filling can start while
the GarconMenu is loading, because its status is updated only at the end
of the loading.

The other occurrence of `garcon_gtk_menu_add()` that fills the root menu
is protected because it is in the GAsyncReadyCallback, so after the task
is finished and before another one is started. As for the third
occurrence of `garcon_gtk_menu_add()` which fills sub-menus, it is
protected by `g_signal_connect_object()` which keeps a reference on the
sub-GarconMenu.

Fixes criticals such as
"g_node_last_child: assertion 'node != NULL' failed".

Fixes: d2c7068e
Related: !18

As the doc states, calling `g_mutex_clear()` on a locked mutex leads to
undefined behavior. This can happen at least in the case of GarconMenu,
where a load may be in progress at the time the last reference is
removed in GarconGtkMenu. This can be reproduced by reloading the panel
configuration via xfce4-panel-profiles when a custom menu file is used.

Fixes: 966f7c99
Related: !18

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

It turn out GtkImage automatically takes UI scale factor into account
when loading images from GIcons.  This allows us to avoid having to
thread through the scale factor everywhere, and also means we don't need
to do anything when the scale factor changes.

This reverts commit 563e07f5.

This reverts commit f1efceb2.

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

This could result in the menu loaded twice in (very) rare cases.

Fixes: d2c7068e
Related: !18

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

Non-trivial functions connected to file monitoring or delayed must be
protected from concurrent execution with `garcon_menu_load()`.

Fixes: d2c7068e
Related: !18

Fixes: d2c7068e
Related: !18

Otherwise there is a time interval during which the id is null while the
object is still alive. This can cause problems especially since the menu
loading is asynchronous (d2c7068e).

Brian Tarricone authored 2 years ago and Gaël Bonithon committed 2 years ago

If the UI is scaled up from 1x, icons need to be rendered at a
higher-multiple pixel value.  The GtkImage can then be created (or
updated) with a scale-aware cairo_surface_t.

Fixes: #33
MR: !25

Only GLib 2.66 will be required for Xfce 4.18.

Fixes: f33c23d2

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

Since Garcon reduces the case of URL desktop files to the case of a
classic file with an Exec key of value `exo-open 'URL'`, and there is no
reliable way to distinguish the two cases from the outside when invoking
`garcon_menu_item_get_command()`, Garcon must escape the '%' characters
in the URL as if they appeared in the value of an Exec key.

Fixes: #31

This partially reverts c709d625.
garcon-marshal.h is installed for some reason.

Although not documented, at least its values should be displayed, since
it is a property of GarconMenuNode.

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).