One of these may be the empty string, if either the autotools build or
meson build is missing.  Passing the variables bare will make the
command line think there's nothing there at all, but quoting an empty
string acts as an empty string command line argument, which 'git diff'
will get confused by.

Usually it's of course a good practice to quote variables that contain
filenames, since they could have spaces in them or other shell-unsafe
characters.  But in this case we know the variable will contain a string
that consists of only letters and dots.

Without this, the first command in the list gets run in xfce-build, but
the rest get run outside the container on the host system.

This is only useful for components packaged in flatpak in practice, i.e.
for Mousepad and Ristretto. There's no point in asking to update this
file if it's irrelevant.

Hopefully this will prevent releasing without changing the version
number.

Makes 'xfce-do-release' as well usable for xfwm4, which has some more
spaces in the line: 'm4_define([xfwm4_version_tag],   [git])'

MR !74

Gaël Bonithon authored 3 years ago and Romain Bouvier committed 3 years ago

The use of `m4_define` is also found in `configure.ac` files, with or
without a version tag, which is not a problem. The use of
`XDT_VERSION_INIT` is probably always exclusive of the use of
`m4_define`, but the filter by grep does not bother.

This adds the new release to the Appdata file if the `<releases>` tag
exists. This file is only searched in the root of the repository and in
the `data` directory, and must be unique.

Gaël Bonithon authored 3 years ago and Simon Steinbeiß committed 3 years ago

* Abort on failure in `sanity_checks()`
* Always test if the version specified exists as a git tag
* Always have a default choice, indicated by a capital letter
* Remove unused function `get_on_with_it()`

Landry Breuil authored 3 years ago and Simon Steinbeiß committed 3 years ago

Works better on OpenBSD now.

Closes: #43


Signed-off-by: Jan Ziak <0xe2.0x9a.0x9b@gmail.com>

The xfce-build container is smaller and also what we use in GitLab CI.