Probably a regression introduced in 2759f19c.

Fixes: #62

Akbarkhon Variskhanov authored 2 years ago and Gaël Bonithon committed 2 years ago

This avoids situations like `export EGREP=egrep; ./autogen.sh`

Fixes #54.

- So we are sure to not print any warning because of a missing m4/
  folder on first aclocal run

- autoreconf already do all the jobs and detections, we don't need to run manually
  multiples binaries
- Remove obsolete checks/warnings we are doing for libtoolize, all our
  components have been ported
- Simply run autoreconf with good options should be enough for
  everything
- We still need to run intltoolize and gtkdocize manually to support
  autotool 2.69
- This fix issue #42

Romain Bouvier authored 4 years ago and Simon Steinbeiß committed 4 years ago

- intltoolize already do all the job that glib-gettextize do (maybe
  since 10 years)
- Remove the XGETTEXT_ARGS custom feature, I can't find any projec using
  this in xfce

- We don't need to find all langugaes at this step, because it is done
  in xdt-i18n.m4 macros since 4.15 when XDT_I18N is called.
- And the "-printf" argument is not supported on BSD find

- quoting
- replace backticks with $()
- replace 'test "x$var"' with 'test "$var"'
- replace $(pwd) with $PWD
- simplify the command to search for languages
- do not use subshell when unneeded
- do not use redirection when unneeded
- directly test command exit codes instead of using $?
- readability (useless ";", indenting)

and more generally special characters different from '\1'.

This is achieved by replacing the filename separator ' ' with '\1' in
lookup_configure_ac_*(), and the default IFS=' \t\n' with IFS='\1', but
only where necessary: the default IFS is usually required for things to
go as expected.

So we have to do an IFS round-trip substitution around each "for" loop
on filenames, just before and just after pathname expansion by the
shell.

Additionally, when running $XDT_PROG_ACLOCAL, one has to define some
new variables ACLOCAL_DIR and use conditional parameter expansion, to
properly set the program flags:
$XDT_PROG_ACLOCAL ${ACLOCAL_DIR:+-I "$ACLOCAL_DIR"}

Finally, one has to take care of some non optional quoting
(strictly speaking, some are optional in this commit, but I preferred
not to cut as close as possible and to keep an overall coherence).

The purpose of the current code seems to be to replace the strings
'\t', '\n' and '\\' by a single space ' ', not the characters
"horizontal tab", "line feed" and "backslash" by a single space.

So the right command to do this is sed, not tr, which doesn't do the
job expected here.

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

There is no guarantee that the configured include dir is in aclocal
default search path. For example, system aclocal may not search for m4
macros under /usr/local.

Fixes #36

Install the m4 macros in location where autoconf will find them by
default.

Adjust xdt-autogen to depend on the default location while still respect
any set ACLOCAL_FLAGS or XDT_ACLOCAL_FLAGS.

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

The `ls *.po | awk ..` pattern is generally not recommended[0]. Replace
it with a tiny for loop with basename. Use POSIX `tr`[1] to delete the
trailing end-of-line, since `echo -n` is not specified in POSIX[2]. This
also removes the need for awk check.

[0]: https://github.com/koalaman/shellcheck/wiki/SC2012#rationale
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/tr.html
[2]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

No need to add the rule to Makefile.am when configure itself can
generate the file.

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

Add an XDT_VERSION_INIT help macro that will define a set of version
macros using esyscmd so we no lnger need to use configure.ac.in to
perpare the version string for AC_INIT.

XDT_VERSION_INIT(SEMVER, [TAG] will set the following macros:
  - xdt_version
  - xdt_version_major
  - xdt_version_minor
  - xdt_version_micro
  - xdt_version_tag
  - xdt_version_build
  - xdt_debug_default

Example usage:

XDT_VERSION_INIT([4.15.3],[git])
AC_INIT([xfce4-someproject], [xdt_version()])
...
XDT_FEATURE_DEBUG([xdt_debug_default])

- Also simplify a bit the XDT_AUTOGEN_REQUIRED_VERSION detection
- Remove the check of the unused doc submodule

- Remove useless macros: m4macros/xdt-python.m4 and m4macros/xdt-xfce.m4
are not used
- Update URLs
- Remove xdt-commit, used to generate Changelog, now done via make
distcheck

Commit de3d7f02 "Display warning if AC_PROG_INTLTOOL is used (bug #8930)"
prints a warning with a hardcoded libtool version. This patch replaces
the hardcoded value with the version number defined in configure.ac.in,
so developers will use the proper requirements.

Update copyright dates, remove subversion $id strings, update .gitignore.

Depending on files generated during build via $(srcdir) breaks builds
that take place outside the source directory. This commit fixes one such
mistake in scripts/Makefile.am that refers to $(srcdir)/xdt-autogen.in.

Similar to AC_PROG_LIBTOOL, which has been replaced with LT_PREREQ
and LT_INIT, AC_PROG_INTLTOOL has been replaced with IT_PROG_INTLTOOL.
This commit makes xdt-autogen recommend intltool >= 0.35.0 and displays
a warning if AC_PROG_INTLTOOL is still being used in a configure script
template.

Original patch by Samuli Suominen <ssuominen@gentoo.org>

Use AUTOCONF_VERSION for automake-$ver, ACLOCAL_VERSION for
aclocal-$ver, AUTOMAKE_VERSION for automake-$ver and
AUTOHEADER_VERSION for autoheader-$ver.

This removes the custom checks for the //newest// binary
version, which gets constantly outdated.

Support LT_PREREQ as the new alternative of AC_PROG_LIBTOOL. If
the latter is used, show a message with information how to switch
to LT_PREREQ.

/bin/sh does not support the -n option for echo. Use printf instead,
which is independent of the shell.

This adds an extra check when XDT_AUTOGEN_CHECK_DOCS
is defined. This variable points to the directory that
should contain the xfce4-docs submodule.

If no submodule clone if found and autogen.sh is running
from within a git clone, it will automatically initialize
the submodule for the user, if not it will show an error
and abort xdt-autogen, since configure will abort too if
we continue because of missing makefile.am files.

we can't tell version ordering, but it's possible it's fine, so just
print a warning and proceed.  autogen.sh writers shouldn't depend on
particular git revisions, only on release versions, but let's soft-allow
it.