- And update configure.ac syntax

- We don't need to find all langugaes at this step, because it is done
  in xdt-i18n.m4 macros since 4.15 when XDT_I18N is called.
- And the "-printf" argument is not supported on BSD find

This command simply updates the container and then exits.

- So now we won't generate a broken container anymore is we can't build
  on component

The xfce-build container is smaller and also what we use in GitLab CI.

This helper enables you to quickly open the GitLab project of your Git
repository in your browser. You can navigate to a subpage by supplying
it as an argument (e.g. "issues").

- We don't need to override CFLAGS when we build the CI container, only
  project built WITH the container needs that
- Also, build is broken because of new line in CFLAGS variable

O H authored 4 years ago and Romain Bouvier committed 4 years ago

A number of common coding errors are missed by the compiler.
They turn up only after release once packages are build with full CFLAGS.

Adjust the gitlab CI to catch such errors:

-Wall enables a number of diagnostics

-Wno-deprecated-declarations will hide a bogus warning.
As long as an API exists it can be used. Noone beside a curious developer
will actually take the time to do research and look for the replacment.
In the wild this warning is just noise in the build log.

-Werror=implicit-function-declaration will point out missing includes.
In case such errors are not fixed, the resulting code will assume int
for function arguments and function return values.

-Werror=return-type will point out incorrect return values. The caller
will most likely receive just garbage.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

- Needed for xfconf distcheck, and might be used in other projects

- quoting
- replace backticks with $()
- replace 'test "x$var"' with 'test "$var"'
- replace $(pwd) with $PWD
- simplify the command to search for languages
- do not use subshell when unneeded
- do not use redirection when unneeded
- directly test command exit codes instead of using $?
- readability (useless ";", indenting)

and more generally special characters different from '\1'.

This is achieved by replacing the filename separator ' ' with '\1' in
lookup_configure_ac_*(), and the default IFS=' \t\n' with IFS='\1', but
only where necessary: the default IFS is usually required for things to
go as expected.

So we have to do an IFS round-trip substitution around each "for" loop
on filenames, just before and just after pathname expansion by the
shell.

Additionally, when running $XDT_PROG_ACLOCAL, one has to define some
new variables ACLOCAL_DIR and use conditional parameter expansion, to
properly set the program flags:
$XDT_PROG_ACLOCAL ${ACLOCAL_DIR:+-I "$ACLOCAL_DIR"}

Finally, one has to take care of some non optional quoting
(strictly speaking, some are optional in this commit, but I preferred
not to cut as close as possible and to keep an overall coherence).

The purpose of the current code seems to be to replace the strings
'\t', '\n' and '\\' by a single space ' ', not the characters
"horizontal tab", "line feed" and "backslash" by a single space.

So the right command to do this is sed, not tr, which doesn't do the
job expected here.

In my tests this works fine, unless I'm missing something
I don't see a reason for writing to files.

Add libgtksourceview-4-dev to support mousepad's transition to it.
Also see apps/mousepad!10

- Needed for catfish build

The forth field of messages such as:
I18n: Add new translation sq (100%).

Is "translation", that's why we should pick the second last field.

Also take further measures to make the container slimmer and more portable.
Thanks to Romain and Florian (schuellerf/xfce-test)!

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

datarootdir should be used instead of datadir.

https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Changed-Directory-Variables.html

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

There is no guarantee that the configured include dir is in aclocal
default search path. For example, system aclocal may not search for m4
macros under /usr/local.

Fixes #36