Landry Breuil authored 3 years ago and Simon Steinbeiß committed 3 years ago

Works better on OpenBSD now.

Fixes #44.

- Fix issue #46
- This code path is almost never used (we don't really test
  minGW/windows), but let's fix this anyway

Alternatively we could also pick the latest overall release, but the
downside would be that the container could jump back and forth between
4.17 dev and 4.16 maintenance releases.
git describe --tags `git rev-list --tags --max-count=1` --match "$NAME*"

- So we are sure to not print any warning because of a missing m4/
  folder on first aclocal run

- autoreconf already do all the jobs and detections, we don't need to run manually
  multiples binaries
- Remove obsolete checks/warnings we are doing for libtoolize, all our
  components have been ported
- Simply run autoreconf with good options should be enough for
  everything
- We still need to run intltoolize and gtkdocize manually to support
  autotool 2.69
- This fix issue #42

By copying the folder contents we don't end up with an additional docs/
folder inside the existing apidocs/ folder.

The static index.html page and artifacts get merged into the newly
added apidocs folder.

Romain Bouvier authored 4 years ago and Simon Steinbeiß committed 4 years ago

- intltoolize already do all the job that glib-gettextize do (maybe
  since 10 years)
- Remove the XGETTEXT_ARGS custom feature, I can't find any projec using
  this in xfce

Romain Bouvier authored 4 years ago and Simon Steinbeiß committed 4 years ago

- This should no be used anymore since last century

Closes: #43


Signed-off-by: Jan Ziak <0xe2.0x9a.0x9b@gmail.com>

- They are obsolete since 2.69, and 2.70 now warn about it
- Bump minimal autoconf to 2.69 (available since 2012)
- AC_HEADER_STDC is not needed anymore: https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Particular-Headers.html

This command prints the versions of the components built within this container, which are located in the /git folder.

- And update configure.ac syntax

- We don't need to find all langugaes at this step, because it is done
  in xdt-i18n.m4 macros since 4.15 when XDT_I18N is called.
- And the "-printf" argument is not supported on BSD find

This command simply updates the container and then exits.

- So now we won't generate a broken container anymore is we can't build
  on component

The xfce-build container is smaller and also what we use in GitLab CI.

This helper enables you to quickly open the GitLab project of your Git
repository in your browser. You can navigate to a subpage by supplying
it as an argument (e.g. "issues").

- We don't need to override CFLAGS when we build the CI container, only
  project built WITH the container needs that
- Also, build is broken because of new line in CFLAGS variable

O H authored 4 years ago and Romain Bouvier committed 4 years ago

A number of common coding errors are missed by the compiler.
They turn up only after release once packages are build with full CFLAGS.

Adjust the gitlab CI to catch such errors:

-Wall enables a number of diagnostics

-Wno-deprecated-declarations will hide a bogus warning.
As long as an API exists it can be used. Noone beside a curious developer
will actually take the time to do research and look for the replacment.
In the wild this warning is just noise in the build log.

-Werror=implicit-function-declaration will point out missing includes.
In case such errors are not fixed, the resulting code will assume int
for function arguments and function return values.

-Werror=return-type will point out incorrect return values. The caller
will most likely receive just garbage.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

- Needed for xfconf distcheck, and might be used in other projects

- quoting
- replace backticks with $()
- replace 'test "x$var"' with 'test "$var"'
- replace $(pwd) with $PWD
- simplify the command to search for languages
- do not use subshell when unneeded
- do not use redirection when unneeded
- directly test command exit codes instead of using $?
- readability (useless ";", indenting)

and more generally special characters different from '\1'.

This is achieved by replacing the filename separator ' ' with '\1' in
lookup_configure_ac_*(), and the default IFS=' \t\n' with IFS='\1', but
only where necessary: the default IFS is usually required for things to
go as expected.

So we have to do an IFS round-trip substitution around each "for" loop
on filenames, just before and just after pathname expansion by the
shell.

Additionally, when running $XDT_PROG_ACLOCAL, one has to define some
new variables ACLOCAL_DIR and use conditional parameter expansion, to
properly set the program flags:
$XDT_PROG_ACLOCAL ${ACLOCAL_DIR:+-I "$ACLOCAL_DIR"}

Finally, one has to take care of some non optional quoting
(strictly speaking, some are optional in this commit, but I preferred
not to cut as close as possible and to keep an overall coherence).

The purpose of the current code seems to be to replace the strings
'\t', '\n' and '\\' by a single space ' ', not the characters
"horizontal tab", "line feed" and "backslash" by a single space.

So the right command to do this is sed, not tr, which doesn't do the
job expected here.