OlivierDuchateau authored 5 years ago and Sean Davis committed 5 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Gusti Ridhoni Syahputera authored 5 years ago and Sean Davis committed 5 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

When inhibiting the screensaver using e.g. xfce4-screensaver-command -q,
xfce4-screensaver would report an error:

org.freedesktop.DBus.Error.ServiceUnknown raised: The name
org.freedesktop.login1 was not provided by any .service files

Consequently, no inhibitor was added to logind. This was due
to the fact that the wrong connection was used for the dbus message and
thus logind expected on the session bus.

Switching to the system connection to correctly relay the inhibitor to
logind.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

The command would not reflect inhibited status and would not show the
inhibitors. This was due to the fact that unref'ing the reply gobject
also invalidates the body extracted from it and the iterator was set up
with the wrong format string.

Also, the body is a container and always contains the inhibitor array
element, even if it's empty. Therefore we have to check the number of
children of the actual array variant and not the body.

Change both to get inhibitors listed and inhibition status shown when
querying status.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

Looking at the timestamps in debug output it seems to me that systemd is simply suspending too fast for xfce4-screensaver to activate the lock screen.

Adding a sleep delay inhibitor lock makes the problem go away since it gives xfce4-screensaver time to activate the lock screen before allowing systemd to continue suspending the system.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

Port over necessary routines from mate screensaver and wire them into
idle screensaving and locking decisions. Do not inhibit explicit
locking e.g. via dbus because it's security relevant and we should
do it if requested explicitly.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

Port over a check from mate screensaver that prevents activation when
clearing an inhibitor by first checking if the session is actually idle.
If clearing the inhibitor is the result of some interactive user action,
this should never be the case and thus prevent e.g. saver activation
when stopping video playback that did inhibit the screen saver.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

141 translated messages, 11 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

136 translated messages, 16 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

114 translated messages, 38 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

134 translated messages, 18 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

151 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

152 translated messages.

Transifex (https://www.transifex.com/xfce/public/).