Signed-off-by Olivier Fourdan <fourdan@xfce.org>
#444
#436
#433
#405

(cherry picked from commit 083e6de0)

Previously we would leak error traps in free_win_data() causing
slowdowns overtime as the list of requests grows.

While fixing the leak is crucial, it also unveiled several places where
actual error traps are missing, causing xfwm4 to abort more often.

Based on XErrors reported, the issue is triggered when freeing pixmaps
or render pictures.

Add more XErrors traps to catch those errors.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
#433
#435
#436
(cherry picked from commit 3119b50b)

147 translated messages, 22 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

140 translated messages, 29 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

139 translated messages, 30 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

167 translated messages, 2 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

125 translated messages, 44 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

bob5972 authored 4 years ago and Olivier Fourdan committed 4 years ago

The function free_win_data() may generate X11 errors as the client
window may already be gone.

To avoid those, the entire function code is supposed to be enclosed
within an error trap/push.

A typo in the code would however push twice instead of a balanced
push/pop which causes the list of event sequences in GDK to grow
indefinitely, leading to slowdowns as the list grows over time.

Fix the leak by balancing the error push with an error pop at the end
of the function.

#351
(cherry picked from commit e6a32cf7)

The function compositorCheckCMSelection() would use the atom index in
our table of atoms, instead of the actual atom, so this is unlikely to
work as expected.

Fix the code to use the appropriate atom as it should.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 78c5dc42)

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

OlivierDuchateau authored 4 years ago and Olivier Fourdan committed 4 years ago

(cherry picked from commit d3e2c246)

A pid is not necessarily a long on all systems, so casting the value of
NET_WM_PID directly into a GPid may cause a stack overflow.

Fixes: 49c1a33a
Closes: #411


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit a691e6c50ce2d797183c98bc2e9c72b8bb2b2a5a)

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Add more XError traps related to XConfigureWindow requests.

#405


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit ec3b1b12)

To be on the safe side.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 9351d439)

The gvalues strings were considered statics, hence not duplicated.

As the caller frees the strings after setting the gvalue, the actual
content would end up pointing at free data.

Consider string gvalues as regular strings, meaning that the given
string value is duplicated as a gvalue.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #406
(cherry picked from commit 056ba6ad)

When xfwm4 needs to kill an unresponsive client, it will use the its PID
is known.

However, the _NET_WM_PID as defined in the extended window manager hint
mechanism is unreliable when the client runs within a sandbox, as it is
the client itself who sets that property using its own view of the PID.

The Xserver can provide a more accurate value of the client PID using
the XRes X11 extension, so use that protocol if available.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 49c1a33a)

The X-Resource extension client library (XRes) allows a client to query
the Xserver for various resources associated with an X11 client,
including its PID.

Add (optional) support for XRes in xfwm4 and use it for getting the
client's PID instead of relying on _NET_WM_PID.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
(cherry picked from commit 010f8281)

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

164 translated messages, 5 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

122 translated messages, 47 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

89 translated messages, 80 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

86 translated messages, 83 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages.

Transifex (https://www.transifex.com/xfce/public/).