When using Xpresent, the compositor maintains multiple pixmap buffers
and therefore needs to accumulate damages for those multiple buffers.

However, when using GLX or no vblank method at all, there is only one
buffer pixmap and there is no need to accumulate damage between buffers.

Currently, the compositor would accumulate damage indefinitely when
using GLX or no vblank, hence damaging way more than actually necessary.

Fix this by accumulating damages only when there is more than one
buffer.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

By definition, the content of the back buffer is undefined, therefore we
need to copy the entire content on flip with GLX.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

XSync can fail, handle the XError gracefully.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #448

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

170 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

170 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Typically, the opaque region applies to the client window.

When shaded, the client window is unmapped and the frame shrunk to its
minimum height.

When shaded, the opaque regio nshould simply be ignored as the client
window is no longer visible.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #452

The opaque region was clipped against the compositor window extents,
which might be larger than the window as it can also include the drop
shadows of the server-side decorations.

Clip the opaque region against the border size and the client size if
available instead.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The client might be gone, and trying to kill the X11 client might cause
an unhandled XError.

Make sure to protect XKillClient against XError.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #453

If the opaque region is correctly translated and intersect with the
actual window extents, there should be no need to generate additional
damages when the opaque region is updated.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The opaque region is set by the client, and applies to the client
window.

Therefore the opaque region should be translated to match the actual
client window, not the composited windows which may be the window
manager frame window.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #452

Small optimization, the clientSize represents the actual client region,
there is no need to recompute that each time when painting.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

We now store the current tile mode along with the client, that makes it
possible to toggle back and forth between tile modes and back to the
initial position/location.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

No need to preset the size when re-computing the tile size.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Tiling works by moving and resizing windows to a specific location  on
screen.

GTK clients using client-side decorations (aka CSD) draw the drop shadow
themselves and use the property _GTK_FRAME_EXTENTS to let the window
manager or compositor know about the actual relative frame size and
location.

GTK automatically removes the drop shadow on some specific window
states, such as fullscreen or maximized, and restores the drop shadow
when the window returns to a normal state.

If that update occurs after the tiled size was computed, the drop shadow
is not accounted for and the window will appear smaller than the actual
expected tiled size.

To avoid that issue, the window manager should recompute the tiled size
whenever the _GTK_FRAME_EXTENTS is updated.

Store the tiled mode and recompute the tiled size/location of windows
when the frame extents or the screen size change.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #450

Right now, resizing a window would immediately update the compositor
representation of that window.

The compositor, however, is able to catch the changes on configure
notify, so there is no need to force that update early.

Remove the resize of the compositor window on each configure requests.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The opaque region is set and updated by the client, which may lag when
the window is resized.

That may leave unpainted areas when resizing a window as the opaque
region set by the client could be actually larger than the window itself
and hence prevent areas to be updated while they should, causing
artifacts on screen.

Make sure to limit the clipping of the opaque region by the window
extents to avoid the issue.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

If a client updates the opaque region of its window, regions previously
opaque may become transparent, meaning that they would need to be
repainted to let other windows underneath see through.

The compositor already computes that and adds damage for the relevant
regions.

Make sure to do that only for visible and redirected windows, other
windows shouldn't trigger that though.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

173 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages, 4 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

163 translated messages, 10 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

123 translated messages, 50 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

123 translated messages, 50 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

172 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

147 translated messages, 26 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

169 translated messages, 4 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

172 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

172 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

171 translated messages, 2 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

170 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

170 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

172 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

160 translated messages, 13 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

172 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).