GTK would update the size increment to match the scale, so when using a
scale 2x the size increment of all windows is set to 2 as well.

As we use the size increment to decide whether to show the position and
resize indicator window, we would end up showing it for all windows
when scale is 2.

Take the scale into account for size increment as well.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The poswin window may become unrealized, use our own instead.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The position/size indicator would be misplaced when a scale is applied.

Take the scale into account to place the indicator on screen.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Small tweak, keep timeout active but to its minimum.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

pnd23@telenet.be authored 5 years ago and Olivier Fourdan committed 5 years ago

Bug 15356

Handle state changes of NET_WM_STATE_HIDDEN to hide or show the client
window.

Tidy up the code.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Update pixmap code to use cairo.

Copied from a similar fix for libwnck by Benjamin Otte <otte@redhat.com>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Add new default theme for xfce 4.14 which integrates nicely with gtk
client side decorations.

Comes in standard, hdpi and xhdpi variants.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Many operations such as XI2's grab/ungrab can cause an XError for
various reasons, and X11 being asynchronous, those may end up being
caught in gdk's own code, causing the termination of xfwm4.

Catch XErrors in the relevant portions in xfwm4 code with error trap
push/pop before gdk get them.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bitmaps (1bpp depth) already represent their mask, do not try to apply
a mask to it.

Fixes the black icons with some legacy apps (xclock, xcalc, nedit, etc.)

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug 14335

Using 10ms means we would miss every vblank on a 144Hz monitor.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Some distributions have shipped an unstable version of xfwm4 with the
“--vblank” command line option, and there are references of that option
out in the wild already.

Restore that command line option, it's also useful for quick tests.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15325

Although XPresent would be the most sensible choice for a lightweight
vblank method, it's still quite fragile and currently broken with
modesettings driver on Xorg 1.20.

GLX seems to work reasonably well on a wide range of hardware and driver
(including closed source drivers) and does not suffer from the lock ups
XPresent may cause on some kernel/driver.

Revert the default vblank method (auto) to GLX for now.

See-also: https://gitlab.freedesktop.org/xorg/xserver/issues/68


Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15061

Make sure to hide the parent frame prior to the client window.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

When closing a window from the menu, an XError with XInput may occur,
within gtk, causing an abort of xfwm4.

From the look of the calltrace, it seems quite similar to GNOME bug
https://bugzilla.gnome.org/show_bug.cgi?id=751739.

Protect the window menu within an error trap to avoid the issue.

It does not make sense to ping a client that we just killed.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15318

Fix a regression where the client would remain visible if closed while
cycling.

Fixes: ef33ff7b "Replace XEvent with XfwmEvent + add xfwm_device..."
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Firefox with client-side decorations lost its hide/maximize ability.

Fixes: d6481d1 "clients: Allow transients to be minimized"
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Jason Zaman authored 6 years ago and Olivier Fourdan committed 6 years ago

Signed-off-by: Jason Zaman <jason@perfinion.com>

Jason Zaman authored 6 years ago and Olivier Fourdan committed 6 years ago

On scaled displays, the menu position needs to be specified in
app-pixels. Some code paths to opening the menu are already in
app-pixels so do not require scaling. The height of the titlebar on
windows with frames always needs to be scaled.

Signed-off-by: Jason Zaman <jason@perfinion.com>

Bug 15303

Now that parent windows get raised along with their transients, no need
to raise them separately.

Bug 15303

Xfwm4 would raise the transients of a given window along with the parent
window, to keep the transients above their parents, but would not raise
the parents along with the transient windows.

Rework the stacking code to raise the deepest parent of a transient
being raised so that all parents window of a transient get raised along
with it.

Bug 14953

Until now, xfwm4 would prevent any sort of transients to be minimized.

Allow regular transients windows to be minimized, while still preventing
dialogs to be minimized independently from their parent window.

Note: This requires a fix in xfce4-panel taskbar to show those windows
(bug 15307), otherwise the user may not be able to restore the windows
once hidden.

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Bug: 15085

We used to keep a logical screen size based on whatever Xlib would
provide, and an actual size based on what we compute based on the actual
monitor layout.

There might be some discrepancies between the two, so let's just get rid
of the logical size.

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Bug: 14990

When a window is iconified, the compositor would keep a copy of its
picture for the window preview in the tabwin.

However, it would still release the picture, and a further XError would
occur when trying to use it.

Bug: 14656

Commit 3877bf45 ("stacking: Raise on focus to activate") caused a
regression with raise-on-focus disabled as it would always raise
regardless of the actual value of the setting.

Raise window on activate only when "raise-on-focus" is enabled.

Bug: 14606

`gdk_pixbuf_get_from_window()` crashes every other call in cairo, there
are apparently a few similar reports.

Just remove the call to `gdk_pixbuf_get_from_window()` as a workaround
for now.

If, for some reason, the xfconf database is broken and the actual button
layout is not available, xfwm4-settings would crash.

Check the settings value to avoid the crash.

Viktor Odintsev authored 6 years ago and Olivier Fourdan committed 6 years ago

Bug: 14741

With gtk+-3.x and XI2, pressing a window button and moving the pointer
out of the window would keep the grab.

Keep a reference of the window where the grab occurred to avoid the
issue.

Martin Husemann authored 6 years ago and Olivier Fourdan committed 6 years ago

Bug: 15028

sn_startup_sequence_get_last_active_time takes two long pointer
arguments, but xfwm4 passes pointers to may-be-different types.

Signed-off-by: Martin Husemann <martin@NetBSD.org>

Make the default theme border 1 pixel larger.

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

168 translated messages.

Transifex (https://www.transifex.com/xfce/public/).