Seems like this is something that broke between XFCE 4.16 and 4.18.
I have a keyboard application shortcut set up which maps the "Audio lower volume" (and raise volume) keys to pamixer commands that raise and lower the volume. IIRC, in 4.16, if I would press and hold the lower volume or raise volume key, XFCE would repeatedly execute the command and so repeatedly update the volume level with just a single key press. This seems to no longer be the case in 4.18. Now even if I press and hold the volume keys, it only executes the command once.
Is there any way to restore the previous functionality? Or perhaps to add a switch to toggle "press and hold" functionality on keyboard shortcuts?
This is a consequence of libxfce4ui@145e2bed, which can indeed be seen as a regression in this case. However, it was only working as a special case of a generally undesirable behavior, i.e. this commit is justified and does fix the problem it was intended to fix.
I'm not sure what should be done here. Maybe actually add an option to allow a shortcut to be repetitive. @lastonestanding any opinion ?
See libxfce4ui!85 (closed). I don't know if it is desirable to expose this setting. I would be tempted to consider it as an advanced setting, documented but to be set via xfconf-query or the settings editor.
Yes, but I wonder if it's worth adding this setting to the interface, regardless of the presentation. I feel like it's still an edge case, although the request is legitimate since there is regression. It also requires adding a new setter to XfceShortcutsProvider, since we can't extend xfce_shortcuts_provider_set_shortcut().
Hmm ... when having it as hidden-only, it probably will be discovered by almost nobody (Hwo actually reads the doc ? :D )
So I suppose it makes sense to as well add some GUI option for it.
That one is for the 'edit-shortcut' dialog in xfce4-keyboard-settings, right ? Actually, I would just add another checkbox. It's a dialog which you don't see often, so I would not care too much to keep it super-slim. (Just noticed that we seem to have multiple dialogs for that same purpose 🤔 )
Done: !93 (closed). As I expected it is quite intrusive on both sides unfortunately (xfce4-settings/libxfce4ui), as the code was not really designed to be scalable.
Fixed in libxfce4ui@a428b73e, backported to 4.18 and 4.16 (since 4.16 also had the fix for libxfce4ui#6 (closed), not yet released in 4.16.2). To be released in libxfce4ui 4.18.1 at some point.