xfsettingsd crash with custom xrandr mode

Submitted by ako..@..il.com

Assigned to Nick Schermer

Link to original bug (#9680)

Description

Hello,

xrandr crashes if a monitor is attached with a custom xrandr mode. Custom xrandr modes are useful when video card and monitor don't work together by default.

So I have this script:

$ cvt 1920 1080 65
# 1920x1080 64.93 Hz (CVT) hsync: 72.98 kHz; pclk: 188.00 MHz
Modeline "1920x1080_65.00"  188.00  1920 2048 2248 2576  1080 1083 1088 1124 -hsync +vsync
$ xrandr --newmode "1920x1080_65.00"  188.00  1920 2048 2248 2576  1080 1083 1088 1124 -hsync +vsync
$ xrandr --addmode VGA1 1920x1080_65.00
$ xrandr --output VGA1 --mode 1920x1080_65.00 --below LVDS1

When trying to start xfsettings I see in console:

(xfsettingsd:2795): Gdk-ERROR **: The program 'xfsettingsd' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.
  (Details: serial 130 error_code 8 request_code 139 minor_code 7)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

This is too bad because a lot of my settings are not applied ever, like touchpad settings and others.

Version: 4.10.0