Pratik Karki authored 6 months ago and Gaël Bonithon committed 6 months ago

Add a 'power_supply' boolean to track power supply status.
Adjust logic to display the 'Fully charged' message correctly based on
whether the device is a power supply. This improves the accuracy of
power status information shown. Additionally, show 0:00 on the plugin
side instead of high number of hours.

Fixes: #240
Signed-off-by: Pratik Karki <pratik@prertik.com>

Pratik Karki authored 7 months ago and Gaël Bonithon committed 7 months ago

visibility logic. Now the label only hides if the state is unknown or
if it is a desktop system.

Fixes: #224
Signed-off-by: Pratik Karki <pratik@prertik.com>

Fixes: #198 (comment 90973)

Fixes: #198

And for min/max values when useful. A few missing initializations are
added in the process.

No Wayland counterpart yet. The wlr-gamma-control protocol offers an
apparently similar feature, but is in fact unrelated to power saving.
However, the Polkit implementation works just as well on Wayland as on
X11.

Many of the disabled paths are temporarily disabled, before a Wayland
implementation is added in future commits. They are therefore only
deactivated at compile time, so that you can have a test version on
Wayland by building with --disable-x11.

Everything to do with keyboard handling (brightness keys, suspend key,
etc.) is not restored on Wayland, since only the compositor is currently
able to manage this.

It is now set in XfpmBrightness, so xfpm_brightness_decrease() and
xfpm_brightness_increase() can work internally as they should. This
significantly simplifies the plugin code.

This also makes the behavior of brightness keys a little more
consistent: if a custom minimum is set (this requires the systray icon
or plugin to be used), it also affects brightness keys, otherwise the
hardware minimum is used (#174).

Finally, the default custom minimum is set a little more intelligently,
depending on hardware delta and setting step.

Fixes: #174
Related: !21, !35

* Make xfpm_brightness_new() a failable constructor, so don't expose
  xfpm_brightness_setup() and remove xfpm_brightness_has_hw().
* Same for XfpmBacklight.
* Remove dead code.

Completes: 47fdeb9c

up_client_new() is transfer full and failable constructor.

The callback for the keyboard brightness keys has its functionality restored,
with clarifying comments added to avoid similar mistakes being made by future
refactoring efforts.

The functions which return the next brightness level to be used are refactored
to ensure the value never decreases below 0 or above the maximum brightness.
Calls to these functions are updated accordingly.

Fixes various critical especially when switching from plugged to
battery.

Make the string more consistent with what we have in the plugin's menu
and what the name of the option suggests (first percentage, then
remaining time).
See also !17 and #128

Simon Steinbeiss authored 4 years ago and Simon Steinbeiß committed 4 years ago

Previously we relied entirely on UPower, now we also check if the icons
used by Gnome are available (battery-level-*).

This commit introduces two new options:
1) Configuring the amount of brightness steps
2) Whether to distribute the steps in a linear or exponential way

Both options are presented in the settings dialog and affect the
brightness keys and the panel plugin.