- quoting
- replace backticks with $()
- replace 'test "x$var"' with 'test "$var"'
- replace $(pwd) with $PWD
- simplify the command to search for languages
- do not use subshell when unneeded
- do not use redirection when unneeded
- directly test command exit codes instead of using $?
- readability (useless ";", indenting)

and more generally special characters different from '\1'.

This is achieved by replacing the filename separator ' ' with '\1' in
lookup_configure_ac_*(), and the default IFS=' \t\n' with IFS='\1', but
only where necessary: the default IFS is usually required for things to
go as expected.

So we have to do an IFS round-trip substitution around each "for" loop
on filenames, just before and just after pathname expansion by the
shell.

Additionally, when running $XDT_PROG_ACLOCAL, one has to define some
new variables ACLOCAL_DIR and use conditional parameter expansion, to
properly set the program flags:
$XDT_PROG_ACLOCAL ${ACLOCAL_DIR:+-I "$ACLOCAL_DIR"}

Finally, one has to take care of some non optional quoting
(strictly speaking, some are optional in this commit, but I preferred
not to cut as close as possible and to keep an overall coherence).

The purpose of the current code seems to be to replace the strings
'\t', '\n' and '\\' by a single space ' ', not the characters
"horizontal tab", "line feed" and "backslash" by a single space.

So the right command to do this is sed, not tr, which doesn't do the
job expected here.

In my tests this works fine, unless I'm missing something
I don't see a reason for writing to files.

Add libgtksourceview-4-dev to support mousepad's transition to it.
Also see apps/mousepad!10

- Needed for catfish build

The forth field of messages such as:
I18n: Add new translation sq (100%).

Is "translation", that's why we should pick the second last field.

Also take further measures to make the container slimmer and more portable.
Thanks to Romain and Florian (schuellerf/xfce-test)!

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

datarootdir should be used instead of datadir.

https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Changed-Directory-Variables.html

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

There is no guarantee that the configured include dir is in aclocal
default search path. For example, system aclocal may not search for m4
macros under /usr/local.

Fixes #36

Install the m4 macros in location where autoconf will find them by
default.

Adjust xdt-autogen to depend on the default location while still respect
any set ACLOCAL_FLAGS or XDT_ACLOCAL_FLAGS.

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

The `ls *.po | awk ..` pattern is generally not recommended[0]. Replace
it with a tiny for loop with basename. Use POSIX `tr`[1] to delete the
trailing end-of-line, since `echo -n` is not specified in POSIX[2]. This
also removes the need for awk check.

[0]: https://github.com/koalaman/shellcheck/wiki/SC2012#rationale
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/tr.html
[2]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

Make the LINGUAS argument optional and let it be auto generated from
po/*.po if is not specified.

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

No need to add the rule to Makefile.am when configure itself can
generate the file.

Natanael Copa authored 4 years ago and Romain Bouvier committed 4 years ago

Add an XDT_VERSION_INIT help macro that will define a set of version
macros using esyscmd so we no lnger need to use configure.ac.in to
perpare the version string for AC_INIT.

XDT_VERSION_INIT(SEMVER, [TAG] will set the following macros:
  - xdt_version
  - xdt_version_major
  - xdt_version_minor
  - xdt_version_micro
  - xdt_version_tag
  - xdt_version_build
  - xdt_debug_default

Example usage:

XDT_VERSION_INIT([4.15.3],[git])
AC_INIT([xfce4-someproject], [xdt_version()])
...
XDT_FEATURE_DEBUG([xdt_debug_default])

- Migrated from the old-csource
- Needed to completely remove exo-csource from exo

Remove --build and --host since they are only needed for crosscompile.
Native builds don't need those and they will not work in case someone
tries build on 32bit.

Also add envronment variables for libdir and libexecdir so the
debian/ubuntu specific lib(exec)dir can be overridden.

Use all cores from `nproc` rather than hardcode parallel jobs to 8.

Allow overide this via environment variable NPROC:
  `docker build --build-arg NPROC=2 ...`

avoid git warning about 'detached HEAD' state by creating a git branch
for the build.