Skip to content

Invalid bookmarks enabled in bookmarks menu

Amrit Kashyap Borah requested to merge Elessar1802/thunar:show-invalid-bookmark into master

Issue: #582 (closed) MR: !211 (merged)

ISSUE

Invalid bookmarks, which were not being removed since (Issue: #47 (closed) MR: !66 (merged)), it would be beneficial to show the invalid bookmarks in the bookmark menu.

CAUSE

thunar_window_menu_add_bookmarks was checking for validity of the bookmark->g_file and overlooking them if they were invalid.

SOLUTION

  • Changed code to add files even if they were invalid. The filename for invalid files is the basename of the bookmark->g_file.
  • Also, refactored the function body.

See Also: Issue: #47 (closed) MR: !66 (merged)

Edited by Amrit Kashyap Borah

Merge request reports