Show invalid bookmarks in Go Menu

With invalid bookmarks no longer being removed (#47 (closed)), it would be beneficial to still show them in the Shortcuts pane and Bookmarks menu. As the paths are invalid, the entries would be disabled in the pane or menu, but ideally the path should still appear in the tooltip or statusbar.

added 5. Bookmarks 5. Side Pane - Shortcuts labels

mentioned in merge request !109 (merged)

it would be beneficial to still show them in the Shortcuts pane

That is already the case, they are just missing in the go menu ... editing bug title

As the paths are invalid, the entries would be disabled in the pane or menu

What you mean by 'disabled' ? Currently some error will pop up when clicked on them, IMO that is fine.

but ideally the path should still appear in the tooltip or statusbar.

As well already the case. Path is shown as tooltip

That is already the case, they are just missing in the go menu ... editing bug title

Oh okay. Thanks.

What you mean by 'disabled' ? Currently some error will pop up when clicked on them, IMO that is fine.

Disabled meaning non-clickable. If your are happy with the current clickable behavior then okay.

As well already the case. Path is shown as tooltip

Don't see any tooltips for menu items, only statusbar text.

removed 5. Side Pane - Shortcuts label

changed title from Show invalid bookmarks in Shortcuts pane and Menu to Show invalid bookmarks in Go Menu

Don't see any tooltips for menu items, only statusbar text.

Yea, for all menus, the tooltip is redirected to the statusbar. The side-pane uses tooltips directly.

Hello, there I want to work upon this I am curious from where does Go menu fetches bookmarks. However, I was expecting it to be just below it

Like you already noticed below, it looks like your current thunar version is a bit outdated and still has bookmarks and go menu mixed in one menu item. In the current master, thunar_window_update_bookmarks_menu will create the bookmarks menu item.

I am also curious that why I don't have Bookmarks as Separate Menu Item beside Go.

Probably you are using some older version of thunar. The separate bookmarks menu-item was introduced in thunar 4.17.7 or 4.17.8. If you are planning to develop on thunar yourself, you anyhow will need the latest master. Here some basic info for building thunar: https://wiki.xfce.org/thunar/dev/build_and_run

So I am trying to understand it, is it that bookmarks are saved in some acceels.scm file? If yes I am unable to find it.

Shortcuts are stored in ~/.config/Thunar/accels.scm. Bookmarks as well can have shortcuts (currently a md5 is used to identify them ... see #295). The actual bookmarks are stored in ~/.config/gtk-3.0/bookmarks (same forall gtk applications)

I was expecting some function to destroy bookmarks when uri is not valid but didn't got any luck

mentioned in merge request !211 (merged)

mentioned in merge request !212 (closed)

mentioned in commit 312ab939

Fixed by above commit, to be released in thunar 4.17.9

closed

added 8. GSoC 2022 label