Update Thunar software components for PCRE2 usage

I noticed that the dependencies for a Linux package of this software contain the information “Requires: libpcre.so.1()(64bit)”.

How will the chances evolve to support the API “PCRE2” (with library versions ≧ 10.40)?

Thanks for reporting ! Afaik the only usage of the pcre is inside thunar-sbr-replace-renamer.c (regular expression support for the bulk renamer)

The used methods are pcre_config, pcre_free, pcre_exec

I currently dont have time to check if/which changes are needed for PCRE2 support.

@ppitu, you know the code well, possibly you are interested in looking into it ?

added 1. Build 5. Bulk Renamer labels

Yes, I can look into it.

And I think pcre2 have a ready function for replacement (pcre2_substitute()) so it's make out code simpler.

I try to solve this issue before the end of week.

Nice, thanks alot @ppitu !

@alexxcons How can I point to compile thunar-sbr plugin, not to install one when I run thunar from terminal? I had this command but I cannot find it.

Not sure what you want to do. For plugins it usually is required to install thunar (and the plugins) in order to test them. It wond work to only launch thunar from source.

Though yes, probably you can set the plugin lookup directory o the according source folder by using autogen.sh with --with-custom-thunarx-dirs-enabled and set the environment variable THUNARX_DIRS to the according source folder. ( Should be possible, though I did not try that myself so far)

I try to set this path but it dont use compile plugins only build one. How do you test changes in plugin?

Just tested myself adding some printf innto thunar_sbr_replace_renamer_pcre_exec, seems to work to make use of it without install:

# ./autogen.sh --with-custom-thunarx-dirs-enabled
# make
# THUNARX_DIRS=~/git/thunar/plugins/thunar-sbr/.libs ./thunar/thunar

Thanks for help. It's work finally :D

Now I have problem how to add pcre2 to project. I try change this line: XDT_CHECK_OPTIONAL_PACKAGE([PCRE2], [libpcre2-8-0], [6.0], [pcre], [Regular expression support]) and in Makefile I add this line: -lpcre2-8 in thunar_sbr_la_LDFLAGS But I think progam dont use pcre2 or there is some truble.

Here a patch: 0001-Use-different-version-of-pcr.patch

Now ./autogen.sh will show the following:

...
checking whether to build the thunar-sbr plugin... yes
checking for pkg-config... (cached) /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for libpcre2-8 >= 10.0... 10.40
checking PCRE_CFLAGS... 
checking PCRE_LIBS... -lpcre2-8
checking for pkg-config... (cached) /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
...

I have libpcre2-8-0 instaled (10.40-1) and libpcre2-dev (debian bookworm). Though I noticed there are already packages for libpcre3 @elfring , I suppose it would make sense to directly go for pcre 3 ?

…, I suppose it would make sense to directly go for pcre 3 ?

I suggest to take another look at the mentioned library version numbers.

Would 10.x be newer than 8.39?

I suggest to take another look at the mentioned library version numbers.

Phew, that is a confusing mess.

So debian lists libpcre3 v.2:8.39-14 as Old »Perl 5 Compatible Regular Expression Library«

and

libpcre2-8-0 - 10.40 is called New »Perl Compatible Regular Expression Library«

so, yea, I suppose the libpcre2 is the more recent one.

Would 10.x be newer than 8.39?

I hope so :D

mentioned in issue #901 (closed)

changed milestone to %Xfce 4.18

mentioned in merge request !287 (closed)

mentioned in merge request !307 (merged)

mentioned in commit 727af5a4

Fixed by above MR, to be released in thunar 4.17.11 in a few days

closed

mentioned in commit 2e3b32c5