Skip to content
Snippets Groups Projects
  1. Jan 12, 2023
  2. Aug 03, 2022
  3. May 12, 2022
  4. Apr 18, 2022
  5. Apr 06, 2022
  6. Mar 22, 2022
  7. Feb 23, 2022
  8. Jan 07, 2022
  9. Aug 15, 2021
  10. Jun 30, 2021
  11. Jun 17, 2021
  12. Jan 23, 2021
  13. Dec 24, 2020
  14. Jul 17, 2020
  15. Apr 19, 2020
  16. Jan 01, 2020
  17. Jul 30, 2019
  18. Apr 14, 2019
  19. Sep 18, 2018
    • Jehan's avatar
      Right mouse click will not display icons for custom actions. · 8349a54d
      Jehan authored and Alexander Schwinn's avatar Alexander Schwinn committed
      (Bug #14685)
      
      g_icon_to_string() is not meant to return an icon name, it returns a
      "textual representation of the icon", which is mostly "proprietary to
      GIcon" (in GIO documentation's own words).
      In particular the reverse function to get a GIcon back from this
      representation is g_icon_new_for_string().
      
      The reason why it used to work was because of a special casing (which
      happens to be the most common case: when you create an icon with a
      single name); yet even if the most common, relying on special cases is a
      bad idea. The special case is about to be reinstated in GLib so it will
      work again as expected, yet only until the next time a widget uses a not
      special-cased GIcon, for instance if using fallback icons. It is better
      to really fix the code.
      
      Now the menu properly recreates the icon using g_icon_new_for_string(),
      not assuming what type of icons it was (it could be an icon name, a
      path, a list of icon names, or whatever else proprietary representation
      any type of icon may use now or in the future).
      Also update the doc of thunarx_menu_item_new() to explicitly states that
      the icon parameter is a textual representation as returned by
      g_icon_to_string(). In particular this won't break any plug-ins as
      single icon names and icon paths are proper representations for icons
      too.
      8349a54d
  20. Jun 02, 2018
  21. Dec 14, 2017
  22. Dec 11, 2017
  23. Dec 10, 2017
  24. Dec 06, 2017
  25. Nov 25, 2017
  26. Nov 22, 2017
  27. Nov 19, 2017
  28. Nov 05, 2017
  29. Nov 04, 2017
  30. Nov 02, 2017
  31. Sep 18, 2017
  32. Aug 26, 2017
  33. Aug 15, 2017
Loading