Non-trivial functions connected to file monitoring or delayed must be
protected from concurrent execution with `garcon_menu_load()`.

Fixes: d2c7068e
Related: !18

Fixes: d2c7068e
Related: !18

Otherwise there is a time interval during which the id is null while the
object is still alive. This can cause problems especially since the menu
loading is asynchronous (d2c7068e).

Brian Tarricone authored 2 years ago and Gaël Bonithon committed 2 years ago

If the UI is scaled up from 1x, icons need to be rendered at a
higher-multiple pixel value.  The GtkImage can then be created (or
updated) with a scale-aware cairo_surface_t.

Fixes: #33
MR: !25

Only GLib 2.66 will be required for Xfce 4.18.

Fixes: f33c23d2

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

38 translated messages.

Transifex (https://explore.transifex.com/xfce/).

Since Garcon reduces the case of URL desktop files to the case of a
classic file with an Exec key of value `exo-open 'URL'`, and there is no
reliable way to distinguish the two cases from the outside when invoking
`garcon_menu_item_get_command()`, Garcon must escape the '%' characters
in the URL as if they appeared in the value of an Exec key.

Fixes: #31

This partially reverts c709d625.
garcon-marshal.h is installed for some reason.

Although not documented, at least its values should be displayed, since
it is a property of GarconMenuNode.

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Amends and completes the previous commit, by systematically using
`g_signal_connect_object()` whenever GarconMenu and GarconGtkMenu are
linked by the connection.

Related: #27, !18, 1ea47477

GarconMenu and GarconGtkMenu have separate life cycles. Therefore, there
is no assurance that the GarconMenu is finalized when the GarconGtkMenu
releases the reference to it upon its own finalization.

Xfdesktop, for example, keeps the same GarconMenu throughout its
lifecycle, while it creates a new GarconGtkMenu each time its context
menu is shown.

Fixes: #27
Related: !18

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

See https://mail.xfce.org/pipermail/xfce4-dev/2022-May/032915.html

This loading makes many disk accesses when reading the `.desktop` files,
which can take several seconds for only a hundred entries, on machines
equipped with mechanical disks and when these files have not yet been
cached.

This way, the loading is done as soon as possible in parallel, and we
wait until it is finished if necessary during a request to show the
menu. We can then start populating the GtkMenu synchronously, according
to the process described in the previous commit message.

Helps: #5, xfce4-panel#485
Fixes: #3, xfce4-panel#184
MR: !18

When the display of menu item icons is required, the creation of the
entire application menu, typically, can take several tenths of a second
or even more than a second on low performance machines. This change
reduces the latency of the menu display, spreading the load over the
display of its submenus and thus doing the rest of the work only if
necessary.

Some of the code in `garcon_gtk_menu_add()` needs to be duplicated to
test for displayable items in a submenu without entering a recursive
process. If a submenu has displayable items, it is added as a menu item,
but is not populated until later, if its display is required.

Unfortunately, for reasons internal to GTK, this process is not easily
parallelized in a GTask like loading the GarconMenu in the next commit.
This is why we have no choice but to delay the task by executing it only
when necessary.

Helps: #5, xfce4-panel#485
MR: !18

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

38 translated messages.

Transifex (https://www.transifex.com/xfce/public/).