Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • xfce-4.18
  • xfce-4.16
  • xfce-4.14
  • xfce-4.12
  • xfce-4.10
  • andrzejr/ellipsize
  • xfce-4.8
  • jannis/hex-sorting
  • jannis/new-shortcuts-pane
  • jannis/file-menu-custom-actions
  • xfce-4.6
  • jannis/desktop-extensions
  • xfce-4.4
  • jannis/folder-thumbnails
  • jannis/lazy-icon-renderer
  • jannis/thunar-vfs-thumbnailer
  • progress-dialog-experiments
  • migration-to-gio
  • thunar-maybe-for-2.0
  • thunar-4.19.2
  • thunar-4.18.10
  • thunar-4.18.9
  • thunar-4.19.1
  • thunar-4.18.8
  • thunar-4.19.0
  • thunar-4.18.7
  • thunar-4.18.6
  • thunar-4.18.5
  • thunar-4.18.4
  • thunar-4.18.3
  • thunar-4.18.2
  • thunar-4.18.1
  • thunar-4.18.0
  • xfce-4.18pre2
  • thunar-4.17.12
  • xfce-4.18pre1
  • thunar-4.17.11
  • thunar-4.17.10
  • thunar-4.17.9
40 results
Search by author
  • Any Author
  • Pratik Karki Pratik Karki prertik
1 author
  1. Sep 25, 2018
  3. Sep 24, 2018
  5. Sep 23, 2018
  7. Sep 20, 2018
  9. Sep 18, 2018
    • Jehan's avatar
      Right mouse click will not display icons for custom actions. · 8349a54d
      Jehan authored and Alexander Schwinn's avatar Alexander Schwinn committed 
      (Bug #14685)

g_icon_to_string() is not meant to return an icon name, it returns a
"textual representation of the icon", which is mostly "proprietary to
GIcon" (in GIO documentation's own words).
In particular the reverse function to get a GIcon back from this
representation is g_icon_new_for_string().

The reason why it used to work was because of a special casing (which
happens to be the most common case: when you create an icon with a
single name); yet even if the most common, relying on special cases is a
bad idea. The special case is about to be reinstated in GLib so it will
work again as expected, yet only until the next time a widget uses a not
special-cased GIcon, for instance if using fallback icons. It is better
to really fix the code.

Now the menu properly recreates the icon using g_icon_new_for_string(),
not assuming what type of icons it was (it could be an icon name, a
path, a list of icon names, or whatever else proprietary representation
any type of icon may use now or in the future).
Also update the doc of thunarx_menu_item_new() to explicitly states that
the icon parameter is a textual representation as returned by
g_icon_to_string(). In particular this won't break any plug-ins as
single icon names and icon paths are proper representations for icons
too.
      8349a54d
    • Elishai Eliyahu's avatar
      I18n: Update translation he (100%). · e2d22a8c
      Elishai Eliyahu authored 
      759 translated messages.

Transifex (https://www.transifex.com/xfce/public/).
      e2d22a8c
  11. Sep 17, 2018
  13. Sep 16, 2018
  15. Sep 15, 2018
  17. Sep 14, 2018
  19. Sep 13, 2018