foobarbyte authored 4 years ago and Arkadiy Illarionov committed 2 years ago

When on_name_changed is called, controlwindow may refer to a window that has been closed. If so, this leads to is_window_on_active_workspace_and_no_other_maximized_windows_above causing a segmentation fault when top_window turns out to be NULL. Since we would like to clear the displayed window title in this case, we should first check whether controlwindow refers to a closed window. It makes sense to do this where we already check if it is NULL or if it refers to the Desktop. We can check this by determining whether the window has a valid PID using wnck_window_get_pid.

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

* Add common configure response callback
* Add common save settings function and use it in configure response
* Add common load settings function

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

* Make create_icon() return WindowIcon and rename to window_icon_new
* Avoid reordering, pack icon depending on prefs
* Remove redundant label variable
* Rename create_symbol to reset_symbol

First argument of create_symbol() is always wckp->prefs->show_app_icon.

37 translated messages, 4 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

* Bump required GTK version to 3.22
* Remove GtkAlignment
* Replace GtkTable with GtkGrid

* use f-strings
* use `subprocess` and `shutil` instead of `os.system`
* use `enumerate` instead of `range(len)`
* remove unused functions
* deduplicate code

28 translated messages, 13 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

* Bump required version to 2.69
* Replace some obsolete macros

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

39 translated messages, 2 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

41 translated messages.

Transifex (https://www.transifex.com/xfce/public/).