92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

56 translated messages, 36 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

Found by: scan-build

Closes #29

This patch fixes "declaration of ‘_g_boolean_var_’ shadows a previous
local [-Wshadow]" warnings.

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

89 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Gaël Bonithon authored 3 years ago and Simon Steinbeiß committed 3 years ago

This fixes a segmentation fault when trying to add clipman as panel
plugin when it is already running as status icon.

Gaël Bonithon authored 3 years ago and Simon Steinbeiß committed 3 years ago

Although it would be better to make full use of GApplication and thus
let the registration process be handled internally after calling
`g_application_run()`, this at least eliminates
GLib-WARNING/GIO-CRITICAL at startup when running `xfce4-clipman`.

Gaël Bonithon authored 3 years ago and Simon Steinbeiß committed 3 years ago

Using a static variable for the source id is not enough here, because
the source is destroyed when the timeout handler returns FALSE, but the
static id isn't reset. Hence, this causes a GLib-CRITICAL when trying to
remove an already removed source on next function call.

This commit fixes this issue, by keeping an approach localized to the
timeout function, and based on the source status.

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

`gtk_clipboard_wait_for_text()` is currently used to request clipboard
text when populating the main menu. This synchronous request causes the
event that triggers menu popup to be dispatched, resulting in a
Gtk-CRITICAL when showing the menu. So let's use
`gtk_clipboard_request_text()` instead, with the necessary adaptations.

O H authored 4 years ago and Simon Steinbeiß committed 3 years ago

G_GNUC_FALLTHROUGH is available since glib 2.60.0.

Fixes commit ecf8b5b2

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Simon Steinbeiß committed 3 years ago

Since commit 2c910275 gtk 3.22 is required.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Simon Steinbeiß committed 3 years ago

plugin.c:63:1: error: no previous prototype for 'plugin_register' [-Werror=missing-prototypes]
menu.c:57:42: error: no previous prototype for 'clipman_menu_get_type' [-Werror=missing-prototypes]
menu.c:521:1: error: no previous prototype for 'clipman_menu_new' [-Werror=missing-prototypes]
collector.c:50:47: error: no previous prototype for 'clipman_collector_get_type' [-Werror=missing-prototypes]
collector.c:235:1: error: no previous prototype for 'clipman_collector_get' [-Werror=missing-prototypes]
collector.c:251:1: error: no previous prototype for 'clipman_collector_show_actions' [-Werror=missing-prototypes]
actions.c:59:45: error: no previous prototype for 'clipman_actions_get_type' [-Werror=missing-prototypes]
actions.c:908:1: error: no previous prototype for 'clipman_actions_get' [-Werror=missing-prototypes]
history.c:46:45: error: no previous prototype for 'clipman_history_get_type' [-Werror=missing-prototypes]
history.c:419:1: error: no previous prototype for 'clipman_history_get' [-Werror=missing-prototypes]

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Simon Steinbeiß committed 3 years ago

Convert the callbacks into a real GSourceFunc.

Some code movement to remove declarations.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

88 translated messages, 4 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

92 translated messages.

Transifex (https://www.transifex.com/xfce/public/).