This could fix a crash or bad behavior in the prefs dialog since visual
was unreffed whereas gdk_x11_screen_lookup_visual() is transfer none
(only functional difference between the two versions).

In the worst case it may be that the only available monitor does not
have these fields filled in (perhaps temporarily). More generally, these
fields may be null and should be handled as such. So if this should be a
problem at some level, another fix should be implemented, without
removing the monitor from the list.

Fixes: #44
Related: c44e5435

151 translated messages.

Transifex (https://explore.transifex.com/xfce/).

This function is duplicated in gs-window-x11.c and
xfce4-screensaver-preferences.c.

Merge the two implementations in xfce-desktop-utils.c and use that
one.

Also, instead of copying environ directly, use g_get_environ().

This allows xfce-do-release to check for the copyright year, in
particular.

Maciej S. Szmigiero authored 4 years ago and Gaël Bonithon committed 2 years ago

Currently, when missing the GNOME Keyring PAM module (an optional
dependency) a warning is logged at each screen unlock:
xfce4-screensaver-dialog[1234]: PAM adding faulty module: /lib64/security/pam_gnome_keyring.so
xfce4-screensaver-dialog[1234]: PAM unable to dlopen(/lib64/security/pam_gnome_keyring.so): /lib64/security/pam_gnome_keyring.so: cannot open shared object file: No such file or directory

Let's hush this warning.

In the current state of the code this only really has an impact on
floaters, where some cleanup takes place before leaving.

A minimal fix that lets GTK create the widget window and then set the
remote window as its parent, rather than forcing its use as widget
window. There may be some unnecessary things to remove after this change
and some cleanup to do more generally, but the idea is to avoid side
effects as much as possible for now.

This hides warnings or other useful messages that should be accessible
without enabling debug mode. On the other hand some warnings should be
lowered to debug level, e.g. AccountsService may not be installed.

Matias De lellis authored 3 years ago and Gaël Bonithon committed 2 years ago

All user dialogs (Linux, Windows, Mac, Android, etc..), or any
representation of a user as an avatar in the web are round
images.

Also, it shows an emblem icon to note that it is logged in as
in other dialogs.

Both options can be made configurable by the user very easily,
but at least (IMHO of course), I think it respects the
preference of the majority of users.

As in all or most other projects, enables same compiler warnings in
particular.

Błażej Szczygieł authored 2 years ago and Gaël Bonithon committed 2 years ago

Always remove sleep inhibit. Fixes few seconds delay when sleeping with
screen locker disabled.

Amends: f2d07a37

Fixes: 7aeced1f

xfconf_channel_get() is transfer none contrary to what the doc says, and
each call of xfconf_init() must be followed by a call of
xfconf_shutdown().

In particular, fixes an unref-critical when closing the prefs dialog.

`xdt-autogen` takes care of this.

Avinash Sonawane authored 2 years ago and Gaël Bonithon committed 2 years ago

-lm is a linker flag.

MR: !14

Maciej S. Szmigiero authored 3 years ago and Gaël Bonithon committed 2 years ago

dialog_timed_out() returns FALSE to remove its GSource but does not zero
the related timeout_id variable which can result in later removal of a
different event source that happen to reuse this id.

Lance Arsenault authored 2 years ago and Gaël Bonithon committed 2 years ago

Fixes: #99
MR: !18

ENABLE_NLS is rarely used and will no longer be supported by
xfce4-dev-tools 4.18.

See https://mail.xfce.org/pipermail/xfce4-dev/2022-May/032915.html

* Remove AM_GLIB_GNU_GETTEXT
* AC_HELP_STRING -> AS_HELP_STRING
* AC_TRY_COMPILE -> AC_COMPILE_IFELSE
* Remove AC_STDC_HEADERS, AC_HEADER_STDC
* AC_OUTPUT -> AC_CONFIG_FILES + AC_OUTPUT

151 translated messages.

Transifex (https://explore.transifex.com/xfce/).

151 translated messages.

Transifex (https://explore.transifex.com/xfce/).

151 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

151 translated messages.

Transifex (https://www.transifex.com/xfce/public/).