Number picker does not accept manually typed values

• Open screensaver preferences
• Change value for: "regard the computer as idle after" by TYPING the value
• Press close
• Open the preferences screen again.
• Shows the old value

Manually typing only seems to work when entering a number lager than 1440 (changing it automatically to this number) The same behavior for the number picker on the "lock screen" tab.

mentioned in issue #95 (closed)

The attached patch seems to fix the master branch. 99_numberPicker.patch

It just changes the GTK signal to connect to from "changed" to "value-changed" for the three Gtk Spin Buttons in this app. Just changes 3 lines in src/xfce4-screensaver-preferences.c from commit as of Fri May 27 00:50:49 2022

I first observed/confirmed the error in a build of the master branch from "git clone https://gitlab.xfce.org/apps/xfce4-screensaver.git" then added these edits and see it how saves this "state" when rerunning it many ways (like above and more); with -/+ button and with the text input box in all 3 Spin Buttons. It's very unclear (to me) why this works from the GTK3 documentation. I just used trial and error to find that this seems to work better. I do not understand why they have a "changed" signal that does not catch all the changes, but maybe a subset of the "value-changed" functionality is need for some reason. Or maybe there are signal aliases that I do not know about.

I request someone confirm this works, makes sense, and then commit these changes. I should not have access to change the code repo.

--lance

It's not obvious how to get this "bug fix" into https://gitlab.xfce.org/apps/xfce4-screensaver . The forks are at a limit (10). I do not see a pull request button on https://gitlab.xfce.org/apps/xfce4-screensaver . I think this is all I can do. See patch file in above comment. I'll try to email a developer too.

cheers lance

Managed to make a fork: https://gitlab.xfce.org/lanceman2/xfce-4-screensaver-issue-99/-/tree/master/ The "fix" changes are now in that fork.

One might consider looking at all GtkSpinButton callbacks in all of XFCE programs. One might consider this a general work around to a GTK3 "bug". It appears that the "changed" signal does not call the callbacks for a text edited value when the text box loses focus after an edit, but the "value-changed" signal does.

In src/xfce4-screensaver-preferences.c the signal for callback function cycle_delay_value_changed_cb may need its signal changed too, but I don't see that widget when I run the program.

--lance

mentioned in merge request !18 (closed)

Same thing happening in Screensaver options -> "Lock Screen" -> "Lock screen with screensaver" -> "Lock the screen after the screensaver is active for:"

I have to manually click the "plus" or "minus" buttons, as is doesn't save the option when entering a number.

assigned to @lanceman2

closed with commit a8f489c4

marked #117 (closed) as a duplicate of this issue

marked this issue as related to #117 (closed)

changed milestone to %4.18.0

marked #95 (closed) as a duplicate of this issue

marked this issue as related to #95 (closed)

marked #61 (closed) as a duplicate of this issue

marked this issue as related to #61 (closed)

marked #56 (closed) as a duplicate of this issue

marked this issue as related to #56 (closed)

marked #52 (closed) as a duplicate of this issue

marked this issue as related to #52 (closed)