So that they have a better chance of being at the top of the stack and
thus being seen by the user, especially for the message dialog.

This reverts commit ebac376a.

There is actually a dialog saying that there is no prefs, I didn't see
it behind the other windows.

Otherwise xfconf functions are called after shutdown.

Previous commit requires GTK 3.24 via libxfce4ui 4.18.

Related: xfce/libxfce4ui!98

This could fix a crash or bad behavior in the prefs dialog since visual
was unreffed whereas gdk_x11_screen_lookup_visual() is transfer none
(only functional difference between the two versions).

In the worst case it may be that the only available monitor does not
have these fields filled in (perhaps temporarily). More generally, these
fields may be null and should be handled as such. So if this should be a
problem at some level, another fix should be implemented, without
removing the monitor from the list.

Fixes: #44
Related: c44e5435

This function is duplicated in gs-window-x11.c and
xfce4-screensaver-preferences.c.

Merge the two implementations in xfce-desktop-utils.c and use that
one.

Also, instead of copying environ directly, use g_get_environ().

This hides warnings or other useful messages that should be accessible
without enabling debug mode. On the other hand some warnings should be
lowered to debug level, e.g. AccountsService may not be installed.

Matias De lellis authored 3 years ago and Gaël Bonithon committed 2 years ago

All user dialogs (Linux, Windows, Mac, Android, etc..), or any
representation of a user as an avatar in the web are round
images.

Also, it shows an emblem icon to note that it is logged in as
in other dialogs.

Both options can be made configurable by the user very easily,
but at least (IMHO of course), I think it respects the
preference of the majority of users.

Błażej Szczygieł authored 2 years ago and Gaël Bonithon committed 2 years ago

Always remove sleep inhibit. Fixes few seconds delay when sleeping with
screen locker disabled.

Amends: f2d07a37

Fixes: 7aeced1f

xfconf_channel_get() is transfer none contrary to what the doc says, and
each call of xfconf_init() must be followed by a call of
xfconf_shutdown().

In particular, fixes an unref-critical when closing the prefs dialog.

Maciej S. Szmigiero authored 3 years ago and Gaël Bonithon committed 2 years ago

dialog_timed_out() returns FALSE to remove its GSource but does not zero
the related timeout_id variable which can result in later removal of a
different event source that happen to reuse this id.

Lance Arsenault authored 2 years ago and Gaël Bonithon committed 2 years ago

Fixes: #99
MR: !18

ENABLE_NLS is rarely used and will no longer be supported by
xfce4-dev-tools 4.18.

OlivierDuchateau authored 5 years ago and Sean Davis committed 4 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

This reverts commit 378c7881.

This reverts commit 37b96373.

O H authored 4 years ago and Sean Davis committed 4 years ago

Similar code to prevent a crash exits elsewhere.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

This reverts commit f596f888.

Fixes #66

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_seconds expects a guint as first argument.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_idle_add expects a GSourceFunc as first argument.
Remove the casts and add proper prototype to affected functions.

Signed-off-by: Olaf Hering <olaf@aepfle.de>