When running xfwm4 from a nested X11 server (Xnest, Xephyr) from within
a Wayland session, GDK will selects in priority the Wayland backend,
which will lead to a crash because xfwm4 is an X11 window manager and
not a Wayland client.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 13954

Commit aee8b25a:

    Do not prevent ALT+Mouse resizing for borderless maximized windows.

Introduced a regression with windows using size increment (like most
terminal emulators).

Fix the size increment issue while preserving the possibility to resize
maximized window.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Andrey Alekseenkov authored 7 years ago and Olivier Fourdan committed 7 years ago

Bug: 13964

Bug: 13970

Not that it matters much in this case though.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

P. Pronk authored 8 years ago and Olivier Fourdan committed 7 years ago

Bug: 13284

When dragging a window from a large monitor to the top of a smaller monitor to
maximize the window, it is possible that the window gets maximised on a
different monitor then the monitor your mouse is.

This happens because clientToggleMaximized uses the center point of the window
to calculate on which monitor the window should be maximised.

To fix this behaviour this commits adds a clientToggleMaximizedAtPoint method
so we can tell on which monitor the window should be maximised.

Xfwm error handler will cover all errors itself, there is no
necessity to use error traps for client.

GDK X error traps were changed in GDK 3 so using these traps
caused unwanted SIGTRAPs within GDK X error handler.

Bug: 13607

If XPresentPixmap() fails, we would disable Present rather that waiting
for a notification that will never arrive.

But that relies on the actual window to be reported in the XError, which
is not necessarily the case.

Disable Xpresent for all screens as we are not sure we can tell which
one from the resource id.

Błażej Szczygieł authored 7 years ago and Olivier Fourdan committed 7 years ago

Bug: 13613

Since commit 7115d1b4, we can't disable second (broken) vblank waiting
code.

glXSwapBuffers() already waits for v-blank (if enabled in driver), so
any other "synthetic" waiting for v-blank can reduce performance
(de-sync) without actual benefit.

This patch removes old code to prevent waiting for vblank twice.

Bug: 13608

Commit 58955779 (Use ximerama indices for _NET_WM_FULLSCREEN_MONITORS)
introduced a regression because the monitor index was wrongly compared
against the total number of monitors, which would falsely assume that
the Xrandr query failed whereas it actually worked.

Fix the false comparison and also use the screen size as fallback values
in case the Xrandr really failed so that we don't end up using random
uninitialized values.

Prefer Present over GLX if both are available, and remove the
environment variable "XFWM4_USE_PRESENT".

Eventually, we'd rather use a command line option instead (TODO).

This is a leftover of the old (broken) vblank code.

Otherwise the current WM window might have vanished and we wouldn't
know.

Bug: 9351

_NET_WM_FULLSCREEN_MONITORS uses Xinerama indices for multi-monitor
fullscreen, but xfwm4 uses gdk indices which may differ.

As a result, depending on the actual layout and which monitor is marked
as primary, a fullscreen window could be placed on the wrong outputs.

Fetch the Xinerama list and use the monitor size from there instead of
relying on gdk monitor indices for _NET_WM_FULLSCREEN_MONITORS

Bug: 12534

This reverts commit 0dfb5540.

Bug: 13454

We would use the first monitor by default, but we'd rather use the
primary monitor.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>