Some menu entries my not trigger a frame redraw, leaving the menu button
depressed.

To avoid that, just schedule a frame redraw for all menu entries.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: xfce/xfwm4#718

clientScreenResize() ensures that tiled, fullscreen and maximized wintod
remain correctly sized when the overall screen size is changed, but also
tries to save and restore window positions in case of relayouts.

Since commit 182bd22c „Update maximized on struts change“ however, we
all clientScreenResize() from workspaceUpdateArea() unconditionally
while workspaceUpdateArea() can be called every time a window is moved.

That causes a regression when moving undecorated windows, typically
those meant to remain fully visible on screen when screen size changes,
and every other move would save and restore the previous position,
causing spurious and unexpected window movements.

To solve the problem, add a new parameter to clientScreenResize() to
specify if the all is originating from a relayout.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Fixes: 182bd22c - Update maximized on struts change
Closes: #677

Enrico Weigelt authored 2 years ago and Olivier Fourdan committed 2 years ago

Aeons ago KDE invented its own (KDE specific) protocol for managing system
trays, which is deprecated for long time. Since around 15 years it's only
built when explicitly enabled and marked unsupported.

Therefore drop the old unsupported stuff.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Avinash Sonawane authored 3 years ago and Olivier Fourdan committed 3 years ago

Found by: scan-build

Radio buttons select window layer. Checkbox button for workspace
pinning.

Signed-off-by: Stephen Robinson <stephen@drsudo.net>

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

xfwm4 expects no keyboard modifiers (other than the usual locks) in
button events to allow interactive resizing.

There is no reason to be so picky, especially considering there is no
such check when moving windows.

Relax the requirements for resizing and allow interactive resize with
the mouse regardless of the modifiers being pressed.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #487

Since 4.14 this is the minimum version for all of Xfce, which allows to
remove a bunch of dead code.

Refs !3

Signed-off-by: Dridi Boukelmoune <dridi@fedoraproject.org>

O H authored 4 years ago and Olivier Fourdan committed 4 years ago

The function prototypes are already a GSourceFunc, no need to cast the pointer.
Remove a gpointer casts.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

Peter de Ridder authored 12 years ago and Olivier Fourdan committed 4 years ago

Note: This cannot work with CSD (client-side decoration), as double-
click is handled by the client and not by the window manager with CSD.

Closes: #1

Debug mode means compiling with "-Werror", clean up various leftovers
breaking the build in debug.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The window menu entries would check for valid transients or modal dialog
window to enable or disable the above/below entries.

Yet the actual above/below function would simply check for any transient
or modal dialog, hence denying the request for fake dialogs without an
actual parent window.

Fix the logic to remain consistent, and allows fake dialogs to be placed
above or below other windows.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes:#458

We now store the current tile mode along with the client, that makes it
possible to toggle back and forth between tile modes and back to the
initial position/location.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Tiling works by moving and resizing windows to a specific location  on
screen.

GTK clients using client-side decorations (aka CSD) draw the drop shadow
themselves and use the property _GTK_FRAME_EXTENTS to let the window
manager or compositor know about the actual relative frame size and
location.

GTK automatically removes the drop shadow on some specific window
states, such as fullscreen or maximized, and restores the drop shadow
when the window returns to a normal state.

If that update occurs after the tiled size was computed, the drop shadow
is not accounted for and the window will appear smaller than the actual
expected tiled size.

To avoid that issue, the window manager should recompute the tiled size
whenever the _GTK_FRAME_EXTENTS is updated.

Store the tiled mode and recompute the tiled size/location of windows
when the frame extents or the screen size change.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #450

When xfwm4 needs to kill an unresponsive client, it will use the its PID
is known.

However, the _NET_WM_PID as defined in the extended window manager hint
mechanism is unreliable when the client runs within a sandbox, as it is
the client itself who sets that property using its own view of the PID.

The Xserver can provide a more accurate value of the client PID using
the XRes X11 extension, so use that protocol if available.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Update the Pango attributes whent he widget font factor is updated, then
repaint all frames.

With this, changing the scaling factor in the appearance settings
updates the title font dynamically as well.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16067

The font height is not used anymore, remove it.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 16711

We need to keep the pango font attributes for the scale with HiDPI.

This reverts commit 34a31e27.

Bug: 16067

The font height might be wrong, just get rid of it.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15974

Raise delay would be ignored, because on focus change, the newly
focused window would be raised as soon as it receives focus.

Use the raise delay timeout instead of raising the window immediately
so that the raise delay remains functional.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 15638

Ignoring all configure requests when maximized or fullscreen is overkill
and prevent valid use cases from working.

This reverts commit 3751c2c7.

Places where the window manager uses the client window are all possible
sources of XError because the window may have vanished and the window
manager won't know until it gets the destroy notification from the
Xserver.

As GDK error handler is smart and uses the serial of the requests to
check for errors, if the XError is not trapped in time it will end up in
GDK and cause an abort.

Protect against such a possibility by making sure cases where the XID
of the client or one of its dependent resources is used remains withing
an error trap/push.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Using just “x” for the name of the generic `XEvent` is really confusing.

Rename it as “xevent” for clarity.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Some more XErrors trap.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Many operations such as XI2's grab/ungrab can cause an XError for
various reasons, and X11 being asynchronous, those may end up being
caught in gdk's own code, causing the termination of xfwm4.

Catch XErrors in the relevant portions in xfwm4 code with error trap
push/pop before gdk get them.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Jason Zaman authored 5 years ago and Olivier Fourdan committed 5 years ago

On scaled displays, the menu position needs to be specified in
app-pixels. Some code paths to opening the menu are already in
app-pixels so do not require scaling. The height of the titlebar on
windows with frames always needs to be scaled.

Signed-off-by: Jason Zaman <jason@perfinion.com>

Bug: 13954

Some clients tend to send us a configure request when transitioning to
maximized, which introduces a race condition because the window manager
will remove the maximized flag when the client resizes itself, now that
we allow for that since commit aee8b25a.

Ignore the configure request from the client when maximized or
fullscreen to work around such behavior from the client.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug 12434

This only applies to fullscreen windows.

Check that value for GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED has actually
changed before reconfiguring the window.

Bug: 14511

GTK+ will update its GTK_FRAME_EXTENTS property continuously even when
the value hasn't actually changed, which causes the maximized state to
be cleared when transitioning to/from fullscreen to maximized.

Check that he extents have changed and reconfigure the client's window
only when the value has changed.

Make traces more consistent.