Skip to content

Update for `xfw_window_x11_get_xid()` in `libxfce4windowing-4.19.3`

Michał Górny requested to merge mgorny/xfdesktop:xfw_window_x11_get_xid into master

Update the code to use the new xfw_window_x11_get_xid() API that was introduced in libxfce4windowing-4.19.3 rather than the old xfw_window_get_id() that was removed in this version. This fixes the build failure.

Fixes #282 (closed)

Note that this doesn't give me a function xfdesktop, just fixes the immediate build failure. There's something else broken, that results in black screen. Possibly relevant:

$ ./src/xfdesktop 
DBG[xfdesktop-application.c:690] xfdesktop_application_theme_changed(): XfdesktopIconView section not found in theme Adwaita-dark, setting our fallback
DBG[xfce-desktop.c:1024] xfce_desktop_set_property(): about to set icon style: 2
DBG[xfdesktop-file-icon-manager.c:2691] xfdesktop_file_icon_manager_workarea_changed(): moving icon view to +0+0
DBG[xfdesktop-file-icon-manager.c:3053] xfdesktop_file_icon_manager_populate_icons(): entering
DBG[xfce-desktop.c:1027] xfce_desktop_set_property(): finished setting icon style
DBG[xfdesktop-icon-view.c:2848] xfdesktop_icon_view_size_allocate(): got size allocation: 1x1+0+0

(xfdesktop:23297): GLib-GObject-CRITICAL **: 20:03:47.116: ../glib-2.78.4/gobject/gsignal.c:2625: signal 'workspace-created' is invalid for instance '0x559f983f6f60' of type 'XfwWorkspaceGroupDummy'

(xfdesktop:23297): GLib-GObject-CRITICAL **: 20:03:47.117: ../glib-2.78.4/gobject/gsignal.c:2625: signal 'workspace-destroyed' is invalid for instance '0x559f983f6f60' of type 'XfwWorkspaceGroupDummy'
DBG[xfdesktop-icon-view-manager.c:433] xfdesktop_icon_view_manager_update_workarea(): new workarea: 3840x2135+0+0
DBG[xfdesktop-file-icon-manager.c:2691] xfdesktop_file_icon_manager_workarea_changed(): moving icon view to +0+0
DBG[xfdesktop-file-icon-manager.c:3360] xfdesktop_file_icon_manager_files_ready(): entering
DBG[xfdesktop-file-icon-manager.c:3360] xfdesktop_file_icon_manager_files_ready(): entering
DBG[xfdesktop-file-icon-manager.c:3360] xfdesktop_file_icon_manager_files_ready(): entering
DBG[xfdesktop-file-icon-manager.c:3360] xfdesktop_file_icon_manager_files_ready(): entering

Merge request reports