xfdesktop no longer builds against libxfce4windowing-4.19.3
libxfce4windowing 4.19.3 removed xfw_window_get_id
function:
commit 37d26946d8c2df7b4adf2add222f89d794c0a5aa
Author: Brian J. Tarricone <brian@tarricone.org>
AuthorDate: 2024-02-26 07:27:28 +0100
Commit: Brian J. Tarricone <brian@tarricone.org>
CommitDate: 2024-02-26 22:25:31 +0100
Add an X11-specific header and xfw_window_get_xid()
This also adds preprocessor defines so applications can determine at
compile-time if X11 and/or Wayland support are compiled in.
commit d7d9bae6294df6fb0b6cefa50d6fe8ee3d1ce800
Author: Brian J. Tarricone <brian@tarricone.org>
AuthorDate: 2024-02-26 07:10:47 +0100
Commit: Brian J. Tarricone <brian@tarricone.org>
CommitDate: 2024-02-26 22:25:31 +0100
Remove xfw_(window|application)_get_id()
This always returned zero on Wayland, which is not useful at all, and
the XID on X11, which is useful, but maybe should be a backend-specific
function.
As a result, xfdesktop no longer builds:
make[3]: Entering directory '/tmp/xfdesktop/settings'
CC xfdesktop_settings-xfdesktop-settings-ui.o
CC xfdesktop_settings-main.o
GEN xfce-backdrop-settings.desktop
main.c: In function ‘is_our_window’:
main.c:1701:29: warning: implicit declaration of function ‘xfw_window_get_id’; did you mean ‘xfw_window_get_icon’? [-Wimplicit-function-declaration]
1701 | Window window_xid = xfw_window_get_id(window);
| ^~~~~~~~~~~~~~~~~
| xfw_window_get_icon
main.c:1701:29: warning: nested extern declaration of ‘xfw_window_get_id’ [-Wnested-externs]
CCLD xfdesktop-settings
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: xfdesktop_settings-main.o: in function `is_our_window':
/tmp/xfdesktop/settings/main.c:1701:(.text+0x2976): undefined reference to `xfw_window_get_id'
collect2: error: ld returned 1 exit status
I'm going to try making a merge request.