Fix gcc-analyzer warnings

One of them is entirely spurious, but was easy to suppress by lightly
rearranging some code.  The other was a real NULL pointer deref, but
fortunately one that should never happen unless the xfdesktop-settings
binary is somehow corrupted.