RFE: "lock screen" should [optionally] send DPMS off signal
Submitted by Konstantin Svist
Assigned to Ali Abdallah @ali
Description
Created attachment 3014 patch to force dpms off on 'lock screen'
"Lock Screen" in "when lid is closed" works fine, but I would like it to also send DPMS off signal to the screen. This can either be hardcoded to happen always or added as an option ("Lock screen and switch display off")
I've modified my local copy to be hardcoded, feel free to use the patch if you want
Patch 3014, "patch to force dpms off on 'lock screen'":
lock-screen-dpms.patch
Version: 1.0.2
Activity
If you use "i3lock --dpms" to lock in xflock4, DPMS off signals are sent. (Even if you use the latter and accidentally move mouse, you can return to off-state by pressing Esc.) I think it is best, if the low-level screenlocker can handle the DPMS thing according to its configuration, so I suggest that you make a bug report against the screensaver/locker utility, if it can't do it well. I think it is best, if the locker can turn display off in the beginning AND after certain time of inacivity. That said, turning display off when closing the laptop lid is always the right thing to do. I would find it odd, if laptops don't do it always automatically.
-
Just for clarification: you are not requesting to turn DPMS off, but to turn display off by DPMS.
I admit that turning monitor off when locking is desirable sometimes, but some people may prefer e.g. to have some fancy animation with xscreensaver. One option could be to use xautolock as an alternative in xflock4. User could choose which command(s) to use for locking then, e.g. to have line xautolock -nowlocker "xscreensaver-command -lock && xset dpms force off" in autostarted applications. (And user would have to start xscreensaver there as well.)
One nice thing to do is to turn display on by DPMS after resuming from suspend or hibernate (when display is possibly locked). I think nobody have anything against that.
-
That's right -- I'm asking to turn off the laptop display off by using DPMS.
I don't see a case where you'd want to keep the laptop screen on while it's closed. I agree, there are cases where the desktop is "cloned" or "extended" to another display (usually external monitor/projector/etc.) -- those displays should not be affected, of course -- unless user explicitly specified they should be.
My previous laptop (from back when I filed the bug) apparently didn't turn off the LVDS backlight on lid close in hardware -- and instead relied on the OS to turn off the backlight.
DPMS at resume is a bad idea -- if user is waiting for laptop to wake up, they may expect to see the logged in environment. If they specified to use a blank screen screensaver, though - then sure :)
-
@ochosisaid:To be honest I'm not sure this is really the right way to go. Screensavers or whatever handles the locking should determine whether to switch off the display or not (based on their configuration). Xfpm overriding that doesn't really make things better in my opinion. So unless there are really good arguments for it, this is a wontfix for me.
And I use my laptop with 2 external monitors at work. And it's not the latest gen, so the video card only supports 2 screens -- so I close the laptop lid to save desk space (and to not block external monitors view)
There is an option (at least in 1.3.0) to just switch off the display when the lid is closed, does that not do what you want?
-
I think we got kind of far away from the original RFE From what I remember, back in 2010 I had a reasonably-common e1505 Dell laptop, which only disabled the LVDS backlight by software. Whenever I would close the lid, I expected the screen to lock with screensaver + turn off by DPMS. That's all this bug was about. N.B. I don't even have that laptop anymore...
(In reply to Simon Steinbeiss from comment 12)
To be honest I'm not sure this is really the right way to go. Screensavers or whatever handles the locking should determine whether to switch off the display or not (based on their configuration). Xfpm overriding that doesn't really make things better in my opinion.
I admit, I hate having PME options in multiple places -- one in power-manager, another in Xscreensaver options... but since you already have them in power-manager, at least make them work right.
There is an option (at least in 1.3.0) to just switch off the display when the lid is closed, does that not do what you want?
Originally, no -- I expected the screen to lock as well. Thanks for fixing bug 6515 btw!
-
@ochosisaid:(In reply to Konstantin Svist from comment 13)
I admit, I hate having PME options in multiple places -- one in power-manager, another in Xscreensaver options... but since you already have them in power-manager, at least make them work right.
They do work right from my pov. Locking simply doesn't include switching off the display, it's as simple as that. You call a locktool/screensaver (which is whatever the user/distro defines) and that's it – responsibility for what happens next is up to the lockscreen.
FWIW, I haven't seen a laptop that didn't switch off its display when the lid was closed (no matter what action was executed), not sure xfpm really needs to interfere there.
Originally, no -- I expected the screen to lock as well. Thanks for fixing bug 6515 btw!
YW :)
mentioned in issue #18 (closed)
mentioned in issue #22
mentioned in issue #24 (closed)
mentioned in issue #56 (closed)
mentioned in issue #57 (closed)
unassigned @ali