Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • thunar thunar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 335
    • Issues 335
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • thunarthunar
  • Merge requests
  • !325

Fix several thumbnailing issues

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alexander Schwinn requested to merge alexxcons/thunar:thumbnail_fixes_size_allocate into master Dec 21, 2022
  • Overview 3
  • Commits 1
  • Pipelines 4
  • Changes 2

It looks like during thumbnail generation permanent 'size-allocate' events did trigger 'thunar_standard_view_size_allocate' which itself stopped any pending thumbnail loading by using 'thunar_standard_view_schedule_thumbnail_timeout'

Using 'thunar_standard_view_request_thumbnails_real' instead, which just attempts to load thumbnails, fixes the bug

Furthermore, the thumbnailer only sets the passed 'request' if it was already set … that does not make much sense.

Fixes #843 (closed) Fixes #933 (closed)

Hopefully as well fixes: Issue #921 Issue #223 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: thumbnail_fixes_size_allocate