Performance regression in thumbs creation

When opening a folder with images for the first time, the performance of the thumbs being created is waaaay slower than 4.16.x. This happens even if sidepane image preview is off.

Version tested: 4.17.11

Do you have tumbler 4.17.x installed too?

added 1. Performance 5. Thumbnails labels

Yes, using tumbler 4.17.3. Check the video:

capture-1670000684285

@Tamaranch Does this look unusual? Did you notice any performance hit when it comes to thumbnail creation?

No, but I'll do a little comparison later. What is the video supposed to show? Is it with Tumbler 4.16 first, then with Tumbler 4.17, or the other way around, or...?

Wow, indeed. The problem is not with Tumbler but with Thunar.

I tested with a folder containing 59 jpegs for a total of 76.5 MB (some are a little less than a mega, some a little more, it's pretty well distributed).

• With Thunar 4.17.12 -> 10 to 12 seconds to display the thumbnails.
• With Thunar 4.16.11 -> 4 to 5 seconds.

This is independent of the Tumbler version (I tested with 4.16.1 and 4.17.3).

Thank you all for reporting, testing and investigation !

If I am not mistaken, it seems only to be a problem for icon-view and compact-view. List View seems to load thumbnails at the same speed than in 4.16.11.

... going to do some bisect.

70cddc4b is the first bad commit

The fix is surprisingly short

0001-Fix-slow-thumbnail-loading-in-icon-compact-view-Issu.patch

… though not clear to me yet why I only saw the bug in icon view. And why request seems to be NULL in some cases (Where it is only updated if not NULL)

It would be great if you could confirm that it fixes the issue

I confirm this patch fixes the issue for me, though I also have this warning:

  CC       thunar-thunar-thumbnailer.o
thunar-thumbnailer.c: In function 'thunar_thumbnailer_queue_files':
thunar-thumbnailer.c:1157:20: warning: comparison between pointer and integer
 1157 |       if (*request != NULL)
      |                    ^~

I also confirm that the issue is only present in compact view and icon view.

added 1. Regression label

mentioned in commit 6c98cba1

Thanks alot for testing @Tamaranch ! Fixed the warning and pushed it … to be released in thunar 4.18

closed

mentioned in merge request !325 (merged)