Vertical split panes

My monitor is rotatable and I mostly use it portrait oriented rather than landscape. If I use the split pane function of Thunar (or Nemo) to show two folders side-by-side, they are tall and very thin. It's usable in this format but it would make a lot more sense to have them one above and one below. In this layout, both panes would be almost square.

Given that the shortcut for split pane is F3, perhaps this could be Shift-F3?

Humm, I dont use splitpane myself, so maybe I am not in a good position to judge if that is realy something we should have.

Though I think it can be done with minimal effort. Just change the orientation of "paned" from GTK_ORIENTATION_HORIZONTAL to GTK_ORIENTATION_VERTICAL. Looks already good to me when doing so in the gtkInspector.

Given that the shortcut for split pane is F3, perhaps this could be Shift-F3?

No, I would not want a different shortcut for it. Just a xfconf setting to use split-pane either in HORIZONTAL or VERTICAL mode should be sufficient.

I dont have time to work on it, though a MR would be welcome !

added 5. Split View label

Hi @orangebowlerhat, I'm glad to see you here!

https://gitlab.xfce.org/xfce/thunar/-/blob/master/thunar/thunar-window.c#L819 is where the pane is created, and the orientation is set. If you need any help or if you change your mind about wanting to implement it, ping me.

@alexxcons, I feel like this is worthwhile, considering that vertical monitors are not that exotic.

I see two ways of implementing this. We either add a preference that controls the orientation for each new window, as you suggested, or we implement the ability to switch pane-type on the fly, as @orangebowlerhat suggested. This would require us to rebuild the pane whenever the orientation changes (there is no way to change the orientation after construction, as far as I can tell, https://docs.gtk.org/gtk3/class.Paned.html).

The second option would add more complexity for a relatively niche feature, and I'm not too keen on that.

Hi @alexxcons, I have tried to do it. Below is an image, is it good? If it is then please assign it to me

Hi @Ethan0456, yes this is what we are all thinking of. The question is how did you implement it (the image only tells me that you changed a simple ENUM value). If you have a solution ready (or WIP), please open a Merge Request.

@orangebowlerhat was also looking into it afaik.

Yes, I have solution ready, I changed orientation in thunar-window.c from horizontal to vertical.

But I have a question, I replaced horizontal split screen with vertical one, so do I make an option instead of checkbox for split screen with horizontal and vertical as options?

Please read the previous comments. I am in support of adding a new preference instead of rebuilding the pane each time the split orientation changes (I don't see another way to change between horizontal and vertical, unless I am missing some part of the API).

Yes I changed value from GTK_ORIENTATION_HORIZONTAL to vertical, adding a new preference might take some time.

@Ethan0456 If you're still working on implementing this, looking at this !185 (merged) might be helpful for seeing how to add a new preference. Do tell if you've changed your mind about implementing it, I'm willing to work on this issue if that's the case.

@hi-im-buggy Yeah Sure, Actually I was successful in changing default horizontal orientation to vertical, but then I tried to add it as a new option but was not able to figure out how this GTK works (and I am still learning OOP) thus I was not able to complete it (and simultaneouly my exams were also near).

@Ethan0456 "Yeah sure", as in you're going to continue it, or as in you're not working on implementing it?

@hi-im-buggy I am not working on implementing it

@alexxcons, I feel like this is worthwhile, considering that vertical monitors are not that exotic.

Alright, than lets have such an option

I see two ways of implementing this. We either add a preference that controls the orientation for each new window, as you suggested, or we implement the ability to switch pane-type on the fly, as @orangebowlerhat suggested. This would require us to rebuild the pane whenever the orientation changes (there is no way to change the orientation after construction, as far as I can tell, https://docs.gtk.org/gtk3/class.Paned.html).

GtkPaned is of the subtype Orientables, so it should be doable via gtk_orientable_set_orientation .. g_object_set on the propery as well might work. (Since GtkInspector is able to change orientattion of the paned while running, I was positive and checked it :D)

Maybe it is possible to directly connect the xfconf property with the orientation property of the paned via g_object_bind_property.

The orientation of the paned is nothing which will need to be changed often, that's why I dont want a shortcut for it.

Haha, right, if gtkinspector can change it so can we XD

I'll never get used to GObject Inheritance XD

added 2. Enhancement label

mentioned in merge request !194 (merged)

mentioned in commit fbd5e3d6

closed with merge request !194 (merged)

Fixed by !194 (merged), thanks to @hi-im-buggy , to be released in thunar 4.17.8

added 8. GSoC 2022 label

marked #1097 (closed) as a duplicate of this issue

marked this issue as related to #1097 (closed)