Thunar Leaking ThunarFile objects

Seens on thunar master and 4.16 when build with ./autogen.sh --enable-debug=full:

--- Leaked a total of 4 ThunarFile objects:
--> file:///home/schwinn/software/thunar_test/missing_folder
--> file:///home/schwinn/software/thunar_test
--> file:///home/schwinn/software/thunar_test/bookmark%20(link)
--> file:///home/schwinn/software/thunar_test/bookmark%20(link)/some%20file

Every folder accessed will increase the leakage

added 1. Performance label

changed the description

mentioned in issue #552 (closed)

Some cleanup: fix-mem-leaks.diff

Remaining objects:

• main view: the initial folder plus its parent (/home/user and /home)
• side pane: the last selected/clicked folder

Thanks for looking into this!

I'll have a look on that diff soon, today it got already too late for me.

Your diff looks good to me / makes sense ! Looks like I set to many references ... meh :/

Hmm, I could apply it now, or wait until all the leaks are found.

You used valgrind to find the related files ?

No, I simply went through the launcher code (file selection). Since you are more familiar with these parts, I have shared my findings so that you can have a look and maybe identify the remaining leaks.

Alright, thank you for the first findings !

Fixed two more now related to the side-panes: 0001-Fixing-various-memory-leaks-Issue-573.patch

Still leakage when directory is changed, have to further search.

For the last leaked ThunarFile I only found out that it is only leaked if detailed-view is used. On icon view no leakage is reported.

The leaked file seems to be a random file of the last directory which was entered before closing thunar. It is as well suficcient to just select some file .. no need to change the directory to trigger the leak.

Did not find anything inside thunar-detailes-view and thunar-column-model. So far no idea where it could be leaked.

Leak will occur when returning FALSE in thunar_details_view_button_press_event

mentioned in commit 7e54fdd3

mentioned in commit 1cbaca33

Pushed now what we found. For the last one I tried alot of things, but now getting out of ideas. It seems to be related to thunar-detailed-view or thunar-list-model. Though I cant say where exactly.

I just investigated about this, and I found out very cursed, and very informative pattern:

If the if clause in thunar_details_view_row_activated is disabled, the first row that is on the screen gets leaked. If the tree view on the left is used, it also gets leaked. What makes it more confusing is that this is true for about 80% of the time.

Could it be related to rendering?

More leaks:

Apparently copy action also causes memory leak. This could give us another hint.

Thanks for further recherche @MShrimp4 ! Meh, so much leakage :(

@alexxcons Commit bdb2f762 might have fixed the memory leak that wasn't solved. Both master branch and xfce-4.16 no more leaks ThunarFile when using detailed-view. Unfortunately file transfer still causes memory leak.

mentioned in merge request !146 (merged)

added 3. Need Info label

I looked again at this matter and noticed that the home folder is still being listed in the leak summery. The following line was added recently by @SKefalidis and appears to be the cause:

https://gitlab.xfce.org/xfce/thunar/-/blob/a3e4e9d725a416fd95b9f2d372c9482fae5538d6/thunar/thunar-window.c#L5629.

mentioned in commit d609d342

mentioned in commit 8572a316

Middle-click on folder in tree-view.

0001-Fix-memory-leak-in-tree-view-Issue-573.patch

Leaks related to thunar-history can be triggered via the following actions:

• open (in) new tab
• open (in) new window
• change view type
• middle-click on toolbar button (back, forward, parent, home)
• split view

Revert the following commits:

• 733e95c3
• 3334a313
• 06eaa4df

Remove these calls:

• https://gitlab.xfce.org/xfce/thunar/-/blob/d2643718823703c580eb20e0383b11807cee0e14/thunar/thunar-action-manager.c#L480
• https://gitlab.xfce.org/xfce/thunar/-/blob/d2643718823703c580eb20e0383b11807cee0e14/thunar/thunar-window.c#L2166 (not strictly related)

It needs to be checked if #319 (closed) is reintroduced and what to do to address #594 (closed).

mentioned in commit cbb05dc0

changed the description

mentioned in commit b3324367

@lastonestanding, should be fixed now, thanks for the hint !

(In the end was just a missing g_object_unref for the current folder during destruction)

I dont see any more "Leaking ThunarFile Object" warnings when building with ./autogen.sh --enable-debug=full ... hope we finally eliminated all of them. -- closing --

closed

reopened

mentioned in commit c70aedb8

mentioned in merge request !297 (closed)

I noticed a new(?) leak related to desktop launchers when opening the folder containing those files:

--- Leaked a total of 2 ThunarFile objects:
--> file:///home/lastonestanding/Desktop/xfce4-about.desktop
--> file:///home/lastonestanding/Desktop/xfce-keyboard-settings.desktop

mentioned in commit 193dff6a

mentioned in commit 396efdce

changed milestone to %4.18.7

removed milestone %4.18.7

mentioned in commit 2bcbad96

mentioned in commit 1ea14707

mentioned in commit 9784a263

removed 3. Need Info label

Most existing ThunarFile leaks meanwhile got mitigated by the above series of commits.

Remaining use-cases which still generate ThunarFile leaks:

• Start a custom action out of the toolbar. (fixed by bb7ea67f or e2177c85)
• When closing thunar while thumbnails are loading
• When opening a new window or a new tab via right-click on a toolbar breadcrumb button
• On simple startup + close the home-folder and the current folder are leaked

--> Strike through when fixed

mentioned in merge request !469 (closed)

Found a new one (on current master/~4.19.2). To reproduce:

1. Run Thunar in terminal, if "restore-tabs" isn't enabled - enable and restart
2. Change directory & close (also reproducible when closing new windows while first one still runs)

Result: URI(s) saved in "last-tabs-left/right" during the previous/first run leak. In other words, it seems to happen when/if "last-tabs-left/right" get overwritten with new URI's (previous ones are then leaked)...

I tested only with icon-view, though I suppose it doesn't really matter.

Tracked it down in thunar_application_command_line. Not 100% sure if done correctly but this fixes it for me without "complaints", either from compiler or during runtime: fix_leak_on_window_close_with_restore_tabs_enabled.patch

It's likely needed on 4.18 as well, however there's another leak there which happens with or without the patch^^, if split-view is enabled (either on startup up, or manually after), with or without changing directories.
In short: opening (+toggling split-view if not on already) and closing Thunar is enough to trigger the leak.
Haven't found the cause yet (it is however fixed in 4.19.2).

Thanks a lot for the investigation, it is much appreciated!

I tweaked the patch a bit (to as well release in the very unlikely case of non-folder files) and pushed it: e4ad0d0e

I as well will happily push fixes for 4.18 leaks, though I suppose it is not worth the effort there.

You're very welcome! It was a pleasure to both contribute and to locate/plug a first leak ever (if memory serves me)

I tweaked the patch a bit (to as well release in the very unlikely case of non-folder files) and pushed it: e4ad0d0e

Lolz, I was so focused on keeping it simple and reusing the existing if (dir != NULL) check that I didn't even register the need to check if dir is a file

I as well will happily push fixes for 4.18 leaks

I'll share whatever I find and/or fix!

though I suppose it is not worth the effort there.

4.20 gonna be out soon!?? :P

mentioned in commit e4ad0d0e

mentioned in commit 21ff6a9c