Regression: GObject-WARNING on closing thunar in some conditions

Regression after the merge of !10 (merged)

sys:1: Warning: invalid unclassed pointer in cast to 'ThunarStandardView'

To reproduce:

• Open two thunar tabs
• change view on second tab
• change view on first tab
• close thunar

Bug found by @reubengreen73: Link to original discussion.

changed the description

Checking with THUNAR_IS_STANDARD_VIEW (window->view) in thunar_window_history_changed() I get no more warning.

GDB backtrace:

#0  0x00007f0298536473 in g_logv () at /usr/lib/libglib-2.0.so.0
#1  0x00007f02985366f0 in g_log () at /usr/lib/libglib-2.0.so.0
#2  0x00007f0298640aa4 in g_type_check_instance_cast () at /usr/lib/libgobject-2.0.so.0
#3  0x0000559dbcb1369f in thunar_window_history_changed (window=0x559dbdd5c3e0) at thunar-window.c:1652
        history = <optimized out>
        __func__ = "thunar_window_history_changed"
#4  0x00007f029861f052 in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#5  0x00007f0298647685 in  () at /usr/lib/libgobject-2.0.so.0
#6  0x00007f029863b41d in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#7  0x00007f029863b980 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#8  0x0000559dbcabd267 in thunar_history_dispose (object=0x7f02880ae0f0) at thunar-history.c:157
        history = 0x7f02880ae0f0
#9  0x00007f029862b5d5 in g_object_unref () at /usr/lib/libgobject-2.0.so.0
#10 0x0000559dbcaff0b4 in thunar_standard_view_finalize (object=0x559dbdd7a4e0) at thunar-standard-view.c:791
        standard_view = 0x559dbdd7a4e0
        __func__ = "thunar_standard_view_finalize"

Interesting ! Thanks for digging into this, that backtrace was really helpful !

I think we can just remove thunar_history_dispose:

static void
thunar_history_dispose (GObject *object)
{
  ThunarHistory *history = THUNAR_HISTORY (object);

  /* disconnect from the current directory */
  thunar_navigator_set_current_directory (THUNAR_NAVIGATOR (history), NULL);

  (*G_OBJECT_CLASS (thunar_history_parent_class)->dispose) (object);
}

As far as I can see, there is no point in setting the current directory to NULL in thunar_history_set_current_directory. Maybe a relict.

Another possibility would be to prevent signal emmission on the end of thunar_history_set_current_directory if the passed directory is NULL.

Attached a patch to remove thunar_history_dispose 0001-Remove-obsolete-dispose-method-Issue-319.patch

Whitespace here:

+  if ( current_directory != NULL)
+    {

closed via commit 06eaa4df

Pushed to master,thank you for review !

mentioned in issue #573