Different looking spot in some themes

In some themes there is a "light" spot on the right side of the menu bar. This wasn't the case in xfce 4.14. Is this a bug in thunar or should the themes be modified?

Numix:

You can also see a difference in Adwaita:

Version: thunar 4.16.0

I think we can blame bad4150b for this visual glitch. Interestingly, it is not exposed at all when using the Greybird theme.

added 5. Visual Appearance label

Using the Material Black Frost theme has a similar problem.

Additionally, the area cannot be used to drag the window anymore.

Meh, such a small spinner causing so much trouble.

Difference to 4.14 is, that the spinner in 4.14, only was visible when it was active. Since its not part of the menu any more, now that is not sufficient when the menu is hidden. (#394 (closed))

Here a workaround: 0001-Only-show-spinner-when-active-Issue-448.patch

Though not sure if that is a proper fix. When the spinner is going to spin, the theme color still looks wrong to me in Numix.

Could we not just revert all the changes (e2df02f8, e959cd8f and bad4150b) and replace the deprecated function call with g_object_set (G_OBJECT (item), "right-justified", TRUE, NULL)?

Indeed, revert and g_object_set (G_OBJECT (item), "right-justified", TRUE, NULL); seems to do the job .. did not know that we just can set the prop like this.

Even when spinning, I did not see any glitch when testing with Numix.

mentioned in issue #452 (closed)

mentioned in commit 3dd0b95c

closed with commit efba7baa

Fixed for master and 4.16 branch, to be released in 4.16.1 and 4.17.0. Thanks alot for the suggestion @lastonestanding !

Thunar 4.16.1 looks good, thank you both :)

It got a little better, but, in the corner is still a piece of ugly.

Did you restart the system? Check at Help/About that you are running the right version.

@Frash As you can see the headline has changed, only the angle has not changed. There was a restart.

Hmm, it works on my system:

Same here, looks good with Material-Black-Frost-3.38 and thunar 4.16.1, cannot reproduce.

It's strange, after one more reboot - it was already normal. The problem is irrelevant.