Crash when opening folder when "save view settings per directory" is enabled

Using thunar + exo master

Edit: Bug only happens when "Save view settings per directory" is enabled .. @reubengreen73 , if you have any idea (If I disable that, it does not matter which view I use .. I cannot reproduce)

Reproducer:

mkdir -p ~/a/folder1
thunar -q;thunar ~

1.) Go to preferences and enable "Save view settings per directory" and "open new windows with": Listview

2.) thunar -q;thunar ~/a/folder1 and select icon view

3.) thunar -q;thunar ~/a and double-click on folder1 (repeat 3.) until crash)

backtrace:

Thread 1 "thunar" received signal SIGSEGV, Segmentation fault.
0x00007ffff7fab155 in exo_tree_view_button_press_event (widget=0x555555bec7e0, 
    event=0x555555cc8b60) at exo-tree-view.c:360
360	  if (GTK_IS_TREE_SELECTION (selection) &&
(gdb) bt
#0  0x00007ffff7fab155 in exo_tree_view_button_press_event
    (widget=0x555555bec7e0, event=0x555555cc8b60) at exo-tree-view.c:360
#1  0x00007ffff7b340db in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#2  0x00007ffff702e092 in g_closure_invoke ()
    at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#3  0x00007ffff703fe3e in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4  0x00007ffff7046209 in g_signal_emit_valist ()
    at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5  0x00007ffff7046bef in g_signal_emit ()
    at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6  0x00007ffff7ade7f4 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#7  0x00007ffff7991b50 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#8  0x00007ffff79937b3 in gtk_main_do_event ()
    at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#9  0x00007ffff767d775 in  () at /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
#10 0x00007ffff76b1272 in  () at /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
#11 0x00007ffff6f3cbab in g_main_context_dispatch ()
    at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#12 0x00007ffff6f3ce58 in  () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#13 0x00007ffff6f3cf0f in g_main_context_iteration ()
    at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#14 0x00007ffff7153425 in g_application_run ()
    at /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
--Type <RET> for more, q to quit, c to continue without paging--
#15 0x000055555557ca35 in main (argc=2, argv=0x7fffffffe178) at main.c:86
(gdb)

Tried to go back in exo history till: 60dfbbc5cb0012541697208fc987a4bab273f6f8 .. but still crash

Using thunar + exo pre1 tag: Same crash Using thunar 1.8.15 + exo master: Finally No crash

So I used git bisect on thunar with exo master: 02eb4c97 is the first bad commit --> Though I am really not sure if I got that bisect right .. I will need to further dig

added 1. Crash / Freeze label

changed the description

changed title from Crash when opening folder after cutting files to Crash when opening folder when "save view settings per directory" is enabled

changed the description

Right, I'll take a look a soon as I have a moment. It look like it might well be related to exo!18 (merged) as that was a change to that code relating to per-directory settings.

Thank you for looking into it !

changed the description

Re-grapping the selection seems to fix the crash ... though I am not sure yet if this breaks something else:

0001-Re-grab-tree-selection-to-prevent-crash-Issue-413.patch

@reubengreen73 You have a much better insight here than I have ... I would be very interested in your opinion on this patch!

Looks promising - I will try to give it a test and have a proper look soon. Thanks for working on this!

(Sorry for going quiet for a few weeks - I've just started a new job and things have been a bit hectic, but hopefully it is calming down a bit now)

I meanwhile did some more testing (selecting/deselecting files, directory specific settings). So far I did not see any negative side effects.

I want to release exo and thunar this weekend to be in time for 4.16-pre2. So I'll just push this one in order to hopefully provide a stable thunar 4.16 :)

moved to exo#46 (closed)