Focus doesn't change when clicking an emblem entry

When you click on an emblem entry in the Emblem tab of the file properties dialog, the cursor/focus doesn't jump to that entry.

Thanks for reporting !

I can reproduce it on master, a patch would be very welcome !

I tracked down that the necessary code should be added on this line, but not sure what the necessary focus command is. https://gitlab.xfce.org/xfce/thunar/-/blob/master/thunar/thunar-emblem-chooser.c#L285

You can set the focus with gtk_widget_grab_focus().

Note that the button itself was configured to not accept focus, so you will have to work on the GtkFlowBox child object (the button's parent widget).

emblem-focus.diff

emblem-focus.diff

Looks good to me, thanks Theo! Because it is just a diff, you think not ready to be pushed ?

I simply have not checked yet if #314 could affect the fix.

added 5. Properties label

added Patch label

added 3. Need Info label

removed 3. Need Info label

mentioned in merge request !50 (merged)

Looks good & works, merged in !50 (merged).

Thanks for the fix Theo !

Fix will be available in thunar 4.16.0

closed