Thunar doesn't update file icons on renaming when using remote locations

Submitted by Alexander Kurakin

Assigned to Xfce Bug Triage

Link to original bug (#16030)

Description

1. Openn 'sftp://host'.
2. Create 'file.html' file.
3. You see HTML icon.
4. Rename: 'file.html' -> 'file.pdf'.
5. You see HTML icon instead of PDF icon (although filename is new).

Thunar 1.6 git branch.

Version: 1.6.17

See also

• https://bugzilla.xfce.org/show_bug.cgi?id=16779

Alexander Schwinn @alexxcons said:

Thanks for reporting ! Bug as well exists on current master. Only an issue for remote locations, because no folder/file monitors are available there. Pressing F5 will update the view manually and show the correct icon.

Note that the bug can as well be reproduced when entering "localhost" remotly. E.g: sftp://user@localhost/home/user/

Patches are welcome !

Alexander Kurakin said:

Patches are welcome

Ok, but what does this:

because no folder/file monitors are available there

could impact to, else?

Alexander Schwinn @alexxcons said:

Ok, but what does this

The rename is e.g. triggered in "thunar_standard_view_action_rename" inside thunar-standard-view.h It would be good to call "thunar_file_reload" if the GFileMonitor of this file is NULL ( probably we need a method on ThunarFile to check that .. similar to thunar_folder_has_folder_monitor on ThunarFolder ).

Alexander Kurakin said:

Thanks!

I meant, shouldn't we do it not at rename, only?

Alexander Schwinn @alexxcons said:

yes, probably as well required on other operations .. (e.g. update folder on paste and cut .. probably whenever a custom action was triggered ) to be checked in detail

Alexander Schwinn @alexxcons closed a related bug:

*** Bug 12569 has been marked as a duplicate of this bug. ***

added 5. Icons label

added 5. GVfs label

added 5. Out of Sync label

Fixed meanwhile / cannot reproduce with thunar master. (Probably fixed by thumbnail / icon request refactorings)

Reproduced 4.18.10. The same for you, @alexxcons ?

Yes, on the 4.18 branch it will only update after F5, while on master it will update directly

closed

@alexxcons , reproduced in Thunar 4.20.1.

@alexxcons , that was meant to be a subject to reopen. The last one, I promise

Cannot reproduce. Works seamless here on master and 4.20.1

Did you use SFTP?

Yes, tried a localhost URL sftp://$USER@localhost/home/$USER/.thunartest/ and as well a real outside URL sftp://$USER@lxlogin.gsi.de/tmp/

Maybe you did the rename outside thunar?

Maybe you did the rename outside thunar?

No.

@alexxcons , Aha, I've got it!

Show thumbnails preference:

• Never, Local Files Only - the issue happens (the icon isn't updated).
• Always - the issue doesn't happen (the icon isn't updated).

Still works here, no matter which thumbnail setting ... possibly you have some special thumbnailer installed for pdf or html? Can you reproduce with other endings? Could you maybe as well test this one on a clean user account?

Could you maybe as well test this one on a clean user account?

The issue happens on a fresh account.

mentioned in issue #1584