Bulk Renamer | Remove characters gives wrong result on long filenames

Thanks for reporting !

for letting my type these long names from the screenshot. And letting me count characters.

On a first try, I cannot reproduce with 4.18.x / master.

Removing up to position 25 for song 5 gave me: 05 Confederate Bills and Pinball Slugs.mp3 which looks correct to me.

Possibly related in renaming them all together ? Could you please paste all song-titles here (I really dont want to type all of them)

added 5. Bulk Renamer label

added 3. Need Info label

Sorry! I didn't think the exact file names were required.

Smog - Sewn to the Sky - 01 Souped Up II.mp3

Smog - Sewn to the Sky - 02 Kings Tongue.mp3

Smog - Sewn to the Sky - 03 Garb.mp3

Smog - Sewn to the Sky - 04 Hollow Out Cakes.mp3

Smog - Sewn to the Sky - 05 Confederate Bills and Pinball Slugs.mp3

Smog - Sewn to the Sky - 06 Coconut Cataract.mp3

Smog - Sewn to the Sky - 07 Fruit Bats.mp3

Smog - Sewn to the Sky - 08 Peach Pit.mp3

Smog - Sewn to the Sky - 09 Disgust.mp3

Smog - Sewn to the Sky - 10 Russian Winter.mp3

Smog - Sewn to the Sky - 11 Polio Shimmy.mp3

Smog - Sewn to the Sky - 12 Smog.mp3

Smog - Sewn to the Sky - 13 Lost My Key.mp3

Smog - Sewn to the Sky - 14 Fried Piper.mp3

Smog - Sewn to the Sky - 15 Fables.mp3

Smog - Sewn to the Sky - 16 Puritan Work Ethic.mp3

Smog - Sewn to the Sky - 17 A Jar of Sand.mp3

Smog - Sewn to the Sky - 18 I Want to Tell You About a Man.mp3

Smog - Sewn to the Sky - 19 Olive Drab Spectre.mp3

Smog - Sewn to the Sky - 20 The Weightlifter.mp3

Here is a touch of those file names: Smog_-_Sewn_to_the_Sky.tar.gz

I can't reproduce it with those files and names (Thunar 4.18.3 on Xubuntu).

@oren-b is this something you can reproduce each time with those specific files? And if you can test with the files attached above, does it do the same with those?

It looks like the rename may have been run a second time on those two files (an additional 25 characters were removed). Is it possible that you hit "Apply" and then "Done" (Done does an apply and close which would run the removal again). This is the only way I can reproduce it, but doing this does give those exact results so maybe that was what happened?

@newhoa you're right, good catch, thanks!

So this in not a bug in the functionality but I think there's a usability issue here because I didn't understand that Done = apply + close. I suggest that after clicking Apply the Done button would be disabled or or something similar.

Thanks a lot for investigation @newhoa !

Here are some options to mitigate the problem, coming to my mind:

[Cancel][Apply and Close][Apply]
[Cancel][Apply]
[Apply] (only one button, because actually the header bar already provides a way to close the window)

I think I would go for 2. ... since it is rather common to have an additional cancel button on dialogs. Though I am almost sure somebody will complain that now one more button needs to be pressed after renaming

somebody will complain that now one more button needs to be pressed after renaming

Lol probably but it is more understandable I think.

How do you feel about [Cancel][Rename] (or Rename All) to mirror the Right Click > Rename dialog? I think it's a little more consistent, and does say what will happen when you push the button. (edit: looks like that was the name at some point previously)

But then you have two buttons that say Rename and one closes the window and one doesn't (although the Bulk Renamer button tooltip does say that the window will remain open so maybe that's okay). Maybe the Rename dialog, since the Rename button also closes the dialog, could be "Rename and Close":

It's a bit uglier but it does better convey what will actually happen.

Anyway, let me know what you'd like (whether it's either of the two above or just sticking with [Cancel] and [Apply]. This is a simple thing I can make a MR for if that's okay.

The additional 'apply' button was added in !80 (merged), because of #22 (closed). So I think we should keep the feature to don't directly close the dialog after hitting 'rename'.

How do you feel about [Cancel][Rename] (or Rename All) to mirror the Right Click > Rename dialog?

Reusing [Cancel][Rename] sounds like a good idea to me ! (Or the old [Cancel][Rename Files], if you prefer). Though to respect #22 (closed), I suppose we either will need to keep the window open after rename, or to add another button.

These two would both be fine with me:

[Cancel][Rename][Rename and Close]
[Cancel][Rename Files][Rename Files and Close]

These two as well would be fine with me, if the window will be kept open after 'rename':

[Close][Rename]
[Close][Rename Files]

This is a simple thing I can make a MR for if that's okay.

Thanks, that would be great ! Just pick the one you prefer

removed 3. Need Info label

mentioned in merge request !334 (merged)

@oren-b I made a MR (!334 (merged)) if you'd like to check that out and see if that looks easier to understand.

@newhoa looks great, thanks!

closed with merge request !334 (merged)

changed milestone to %4.19.0

Bulk Renamer | Remove characters gives wrong result on long filenames

Designs

Child items 0

Activity