It doesn't seem to be of any use to anyone, and it's weighing down the
build.

And in fact enable GNU symbol visibility which was previously disabled.

In order to make the kernel reclaim unused memory

MR !599

Brian Tarricone authored 5 months ago and Alexander Schwinn committed 4 months ago

After writing a destination file in a copy, the file (or at least parts
of it) will likely still be in the OS's buffer cache.  This means that
when we read it back to compare it with the source, we're just comparing
with what's in memory, not with what's on disk.

On Linux, we can use O_DIRECT when opening the file in order to bypass
the buffer cache.  Other OS-specific code will have to be added in order
to support stronger verification on non-Linux OSes.

This code path is only used when the destination GFile has a file://
URI, as we can't open files this way when using any of GIO's/GVFS's
other URI-scheme backends.  Note that, even if opening with O_DIRECT
succeeds, this is no guarantee that we are actually getting back the
bytes that are on the disk.  Some disks may "lie" that they've flushed
all data and instead return cached data.  Some filesystems -- especially
network filesystems -- may return cached data.

Closes #1471

Fixes #1403

Đoàn Trần Công Danh authored 11 months ago and Gaël Bonithon committed 11 months ago

Strictly speaking, only ${gettextdatadir}/its/polkit.{its,loc}
is required for l10n.

Required by 0d6c6dbb

Gaël Bonithon authored 1 year ago and Alexander Schwinn committed 1 year ago

MR !388

It is no longer needed since !335.

Followup of MR !335

MR !335