The position window is currently just a debug helper, that can only be
enabled by explicitly passing extra CFLAGS (-DSHOW_POSITION).

Some distros already do that, but that's rather invasive from distro pov
(using such undocumented tricks isn't actually a clean approach), and
users asked for this as a general feature.

A trivial solution is adding a configure option for that. It still needs
to be enabled at compile-time, but at least needs less special hacks
and easier to maintain by standard distro build machineries.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Sometimes it might happen that a stale lockfile is left over,
causing distcheck to fail (causing the gitlab pipeline to fail).

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Some files generated by `make distcheck` haven't been catched
by .gitignore yet.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

When requested monitor number doesn't exist, then gdk_display_get_monitor()
returns NULL - there shouldn't be any operations tried on NULL objects.
In the current implementation the caller doesn't know whether the call
actually succeeds.

Therefore add a safety check and report back via return code. This also has
the nice side effect that it makes looping easier.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

The symbol HAVE_PRESENT_EXTENSION is either defined or not,
thus we have to use #ifdef instead #if

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

The format string expected long int, but parameter is long long int.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

175 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

The struts are in client coordinate space, we need to take the scale of
the output into account.

Closes: xfce/xfwm4#659


Fixes: 7e8d60bb
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Since commit 7e8d60bb (Ignore struts from windows on other monitors),
the work area is limited to the primary monitor ony.

As a result, when a panel is placed on a non-primary output, the workarea
does not actually change.

But we would update the maximized window size and position only when the
workarea changed, which is now wrong, we need to update any time the
struts change.

Closes: xfce/xfwm4#658


Fixes: 7e8d60bb
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

The menu code checks for the possibility to grab the keyboard and mouse
prior to open the menu.

But that should not be needed, and induces multiple round trips to the
Xserver.

Let's just drop that code.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

When switching workspaces using the keyboard, the focus is lost and
any later keyboard shortcuts fail.

This is because of commit 3ff334f5 - "Check for user focus for when
passing focus".

The problem is that the code checks for the current focused (or pending)
window, but does not actually verify that neither are non NULL.

This partially reverts commit 3ff334f5

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

XGetGeometry() returns a nonzero status  on  success; otherwise, it
returns a zero status.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Fixes: a7971823  - icons: Gracefully handle non-existent icons
Closes: xfce/xfwm4#656

The content of newly created pixmap is actually undefined and may
content random data, make sure we clear the root backing pixmaps at
creation.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: xfce/xfwm4#649

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

175 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

Simon Steinbeiss authored 2 years ago and Olivier Fourdan committed 2 years ago

For reference see https://code.launchpad.net/~invidian/intltool/fix-dangling-lock-file/+merge/400825

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

175 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

175 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

175 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

175 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

The location needs to take the client-side decorations when computing
the window position.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

When mapping a new window for the first time, the client may set an
opaque region prior to draw anything.

As opaquere regions are meant to hint the compositor that anything
underneath doesn't need updating (as hidden behind an opaque region,
precisely), xfwm4 would leave that region untouched.

However, when using double buffering as with xpresent, it means that
content of the different buffers may end up being different if there is
any damage occurring underneath the opaque region, before the client
itself has painted anything.

As the buffers alternate quickly, the content behind the opaque region
will show alternatively which is ugly (although technically correct).

To avoid that issue, when setting the opaque region first, make sure to
damage the whole window so that the content of the different buffers
remain updated even if behind the opaque region.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: xfce/xfwm4#583
Fixes: 50d34206 - Damage opaque region if changed

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

177 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

Simon Steinbeiss authored 3 years ago and Olivier Fourdan committed 3 years ago

This makes the settings dialogs consistent with how we amended other
settings dialogs in Xfce 4.16

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).

178 translated messages.

Transifex (https://www.transifex.com/xfce/public/).